jenkins-bot has submitted this change and it was merged.
Change subject: Show snak type in summary for novalue and somevalue snaks
......................................................................
Show snak type in summary for novalue and somevalue snaks
Change-Id: If5ebf96a10d8a847360501be431c9227810f7cce
---
M repo/includes/ClaimSummaryBuilder.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Addshore: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/includes/ClaimSummaryBuilder.php
b/repo/includes/ClaimSummaryBuilder.php
index b1e2675..e338fd0 100644
--- a/repo/includes/ClaimSummaryBuilder.php
+++ b/repo/includes/ClaimSummaryBuilder.php
@@ -135,7 +135,7 @@
$value = $value->getTime();
}
} else {
- $value = '-'; // todo handle no values
in general way (needed elsewhere)
+ $value = $snak->getType(); // todo
handle no values in general way (needed elsewhere)
}
$pairs[$key][] = $value;
--
To view, visit https://gerrit.wikimedia.org/r/81187
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If5ebf96a10d8a847360501be431c9227810f7cce
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
