Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/81210
Change subject: Add test for null precision ...................................................................... Add test for null precision Change-Id: I2ae5d7d0cf829a369a57fe67e8bff1278a4bcc4e --- M DataValues/tests/phpunit/GlobeCoordinateValueTest.php 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DataValues refs/changes/10/81210/1 diff --git a/DataValues/tests/phpunit/GlobeCoordinateValueTest.php b/DataValues/tests/phpunit/GlobeCoordinateValueTest.php index c6d224e..8d8c2cd 100644 --- a/DataValues/tests/phpunit/GlobeCoordinateValueTest.php +++ b/DataValues/tests/phpunit/GlobeCoordinateValueTest.php @@ -165,6 +165,17 @@ $geoCoordinate = unserialize( 'C:29:"DataValues\GeoCoordinateValue":27:{[-4.2,-42,9001,0.01,"mars"]}' ); $this->assertInstanceOf( $this->getClass(), $geoCoordinate ); + + $geoCoordinate = unserialize( 'C:29:"DataValues\GeoCoordinateValue":27:{[-4.2,-42,null,null,"mars"]}' ); + $this->assertInstanceOf( $this->getClass(), $geoCoordinate ); + + $this->assertEquals( -4.2, $geoCoordinate->getLatitude() ); + $this->assertEquals( -42, $geoCoordinate->getLongitude() ); + $this->assertEquals( null, $geoCoordinate->getPrecision() ); + $this->assertEquals( 'mars', $geoCoordinate->getGlobe() ); + + $geoCoordinate = unserialize( 'C:29:"DataValues\GeoCoordinateValue":27:{[-4.2,-42,9001,null,"mars"]}' ); + $this->assertInstanceOf( $this->getClass(), $geoCoordinate ); } } -- To view, visit https://gerrit.wikimedia.org/r/81210 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2ae5d7d0cf829a369a57fe67e8bff1278a4bcc4e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DataValues Gerrit-Branch: master Gerrit-Owner: Addshore <addshorew...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits