Aude has submitted this change and it was merged.
Change subject: Hide errors from the property parser func for now.
......................................................................
Hide errors from the property parser func for now.
Many geo-coordinates trigger spurious error messages on wikipedia
at the moment. We'll just ignore these errors for now, to avoid confusion.
Change-Id: I8166f3c1fdafa1dea8fef455c7dbc03acaaed6b3
---
M client/includes/parserhooks/PropertyParserFunction.php
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Aude: Verified; Looks good to me, approved
diff --git a/client/includes/parserhooks/PropertyParserFunction.php
b/client/includes/parserhooks/PropertyParserFunction.php
index 4941640..4721b78 100644
--- a/client/includes/parserhooks/PropertyParserFunction.php
+++ b/client/includes/parserhooks/PropertyParserFunction.php
@@ -199,7 +199,7 @@
$status = $instance->renderForEntityId( $entityId,
$propertyLabel );
- if ( !$status->isGood() ) {
+ if ( !$status->isGood() && false ) { // patched out to hide
issue with geo-coordinat data type for now.
// stuff the error messages into the ParserOutput, so
we can render them later somewhere
$errors = $parser->getOutput()->getExtensionData(
'wikibase-property-render-errors' );
@@ -207,7 +207,7 @@
$errors = array();
}
- //XXX: if Status sucked less, we'd could get an array
of Message objects
+ //XXX: if Status sucked less, we could get an array of
Message objects
$errors[] = $status->getWikiText();
$parser->getOutput()->setExtensionData(
'wikibase-property-render-errors', $errors );
--
To view, visit https://gerrit.wikimedia.org/r/81235
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8166f3c1fdafa1dea8fef455c7dbc03acaaed6b3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: mw1.22-wmf11
Gerrit-Owner: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
