Matmarex has uploaded a new change for review.
https://gerrit.wikimedia.org/r/81502
Change subject: ext.echo.badge: Remove defunct CSS rule
......................................................................
ext.echo.badge: Remove defunct CSS rule
The space after colon on this line is actually a non-breaking space
( ), which is not allowed in this place according to CSS syntax.
Therefore all browsers ignored this rule (logging an error like
"Invalid CSS property value") and the shadow was never shown.
We could fix the rule instead, but I'm pretty sure users are used to
this by now, and in my opinion it looks better without shadow.
Change-Id: I1fd508d2059bec5cd79a6dcdce8dc9be6e6d4229
---
M modules/badge/ext.echo.badge.css
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/02/81502/1
diff --git a/modules/badge/ext.echo.badge.css b/modules/badge/ext.echo.badge.css
index 26146c8..2c99fcb 100644
--- a/modules/badge/ext.echo.badge.css
+++ b/modules/badge/ext.echo.badge.css
@@ -8,7 +8,6 @@
background-color: #d2d2d2;
font-weight: bold;
color: white;
- text-shadow: 0 1px rgba(0, 0, 0, 0.4);
cursor: pointer;
text-decoration: none;
}
--
To view, visit https://gerrit.wikimedia.org/r/81502
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1fd508d2059bec5cd79a6dcdce8dc9be6e6d4229
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Matmarex <matma....@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
