J has submitted this change and it was merged.

Change subject: Fixes bug 43747 by removing z-index on menu
......................................................................


Fixes bug 43747 by removing z-index on menu

Change-Id: Icfa32d731c87099d1c4d06eb3a5860f66ae900ad
---
M MwEmbedModules/EmbedPlayer/resources/skins/kskin/mw.PlayerSkinKskin.js
M MwEmbedModules/TimedText/resources/mw.TimedText.js
2 files changed, 2 insertions(+), 5 deletions(-)

Approvals:
  J: Verified; Looks good to me, approved
  jenkins-bot: Checked



diff --git 
a/MwEmbedModules/EmbedPlayer/resources/skins/kskin/mw.PlayerSkinKskin.js 
b/MwEmbedModules/EmbedPlayer/resources/skins/kskin/mw.PlayerSkinKskin.js
index 1f9ced1..03c59a0 100644
--- a/MwEmbedModules/EmbedPlayer/resources/skins/kskin/mw.PlayerSkinKskin.js
+++ b/MwEmbedModules/EmbedPlayer/resources/skins/kskin/mw.PlayerSkinKskin.js
@@ -66,8 +66,7 @@
                                                'width' : '100%',
                                                'position': 'absolute',
                                                'top' : '0px',
-                                               'bottom' : ( 
ctrlObj.getHeight() + 2 ) + 'px',
-                                               'z-index': '3'
+                                               'bottom' : ( 
ctrlObj.getHeight() + 2 ) + 'px'
                                        } );
 
                                // Note safari can't display video overlays 
with text:
diff --git a/MwEmbedModules/TimedText/resources/mw.TimedText.js 
b/MwEmbedModules/TimedText/resources/mw.TimedText.js
index f45f222..7a99a47 100644
--- a/MwEmbedModules/TimedText/resources/mw.TimedText.js
+++ b/MwEmbedModules/TimedText/resources/mw.TimedText.js
@@ -365,7 +365,6 @@
                                                .attr( 'id', textMenuId )
                                                .css( {
                                                        'position'      : 
'absolute',
-                                                       'z-index'       : 10,
                                                        'height'        : 
'180px',
                                                        'width'         : 
'180px',
                                                        'font-size'     : 
'12px',
@@ -1211,8 +1210,7 @@
                                        'width': '100%',
                                        'display': 'block',
                                        'opacity': .8,
-                                       'text-align': 'center',
-                                       'z-index': 2
+                                       'text-align': 'center'
                                };
                        baseCss =$.extend( baseCss, 
this.getInterfaceSizeTextCss({
                                'width' :  
this.embedPlayer.getInterface().width(),

-- 
To view, visit https://gerrit.wikimedia.org/r/81570
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icfa32d731c87099d1c4d06eb3a5860f66ae900ad
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Mdale <md...@wikimedia.org>
Gerrit-Reviewer: J <jger...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to