jenkins-bot has submitted this change and it was merged. Change subject: Add group to internal list items in test data ......................................................................
Add group to internal list items in test data Previously we were just omitting the first parameter to queueItemHtml() Change-Id: Ib4b6d2877d6cfe6b8469a300f89a4a54cbec6da3 --- M modules/ve/test/dm/ve.dm.example.js 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Esanders: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/ve/test/dm/ve.dm.example.js b/modules/ve/test/dm/ve.dm.example.js index 2e941c5..b21fe09 100644 --- a/modules/ve/test/dm/ve.dm.example.js +++ b/modules/ve/test/dm/ve.dm.example.js @@ -126,6 +126,7 @@ if ( object[name].internalItems ) { for ( i = 0; i < object[name].internalItems.length; i++ ) { doc.internalList.queueItemHtml( + object[name].internalItems[i].group, object[name].internalItems[i].key, object[name].internalItems[i].body ); @@ -412,8 +413,8 @@ ]; ve.dm.example.internalData.internalItems = [ - { 'key': 'bar', 'body': 'Bar' }, - { 'key': 'baz', 'body': 'Baz' } + { 'group': 'test', 'key': 'bar', 'body': 'Bar' }, + { 'group': 'test', 'key': 'baz', 'body': 'Baz' } ]; ve.dm.example.withMeta = [ -- To view, visit https://gerrit.wikimedia.org/r/82788 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4b6d2877d6cfe6b8469a300f89a4a54cbec6da3 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Catrope <roan.katt...@gmail.com> Gerrit-Reviewer: Esanders <esand...@wikimedia.org> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits