Yuvipanda has uploaded a new change for review.
https://gerrit.wikimedia.org/r/83082
Change subject: Set red asterisk on field labels onlf it is marked required
......................................................................
Set red asterisk on field labels onlf it is marked required
Before this, fields had a red asterisk even if they were not
marked with a 'required': true property declaration. This
was confusing for both organizers (who were wondering why this
field was left empty) and for users (who were wondering why this
was marked required, but not really)
Bug: 53842
Change-Id: Ifdd570004d945fcc8e424645eb2d8d4735e3698f
---
M resources/mw.UploadWizardDetails.js
1 file changed, 10 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard
refs/changes/82/83082/1
diff --git a/resources/mw.UploadWizardDetails.js
b/resources/mw.UploadWizardDetails.js
index 83979a7..6553c49 100644
--- a/resources/mw.UploadWizardDetails.js
+++ b/resources/mw.UploadWizardDetails.js
@@ -236,12 +236,18 @@
break;
}
+
_this.$form.append(
$( '<div>' ).attr( 'class',
'mwe-upwiz-details-input-error' )
- .append( $( '<label>' ).attr( {
'class': 'mwe-validator-error', 'for': fieldInputId, 'generated': 'true' } ) ),
- $( '<div>' ).attr( 'class',
'mwe-upwiz-details-fieldname' ).html( field.label ).requiredFieldLabel(),
- $( '<div>' ).attr( 'class', 'mwe-id-field' )
- .append( $fieldInput )
+ .append( $( '<label>' ).attr( {
'class': 'mwe-validator-error', 'for': fieldInputId, 'generated': 'true' } ) )
+ );
+ if ( field.required ) {
+ _this.$form.append( $( '<div>' ).attr( 'class',
'mwe-upwiz-details-fieldname' ).html( field.label ).requiredFieldLabel() );
+ } else {
+ _this.$form.append( $( '<div>' ).attr( 'class',
'mwe-upwiz-details-fieldname' ).html( field.label ) );
+ }
+ _this.$form.append(
+ $( '<div>' ).attr( 'class', 'mwe-id-field'
).append( $fieldInput )
);
_this.fields.push( $fieldInput );
--
To view, visit https://gerrit.wikimedia.org/r/83082
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifdd570004d945fcc8e424645eb2d8d4735e3698f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: Yuvipanda <yuvipa...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
