Hashar has submitted this change and it was merged.
Change subject: git-changed-in-head now always returns 0
......................................................................
git-changed-in-head now always returns 0
A change deleting a single PHP file, would make git show to return an
empty list. The grep command would thus fail to find a newline '^$' and
exit 1 which breaks the Jenkins job.
By using `|| :`, we make sure the exit code will be 0 and the Jenkins
job can continue its processing.
Change-Id: Ib31e89fcaf59df6f8d01f4e785576247dd6cae42
---
M bin/git-changed-in-head
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Hashar: Verified; Looks good to me, approved
diff --git a/bin/git-changed-in-head b/bin/git-changed-in-head
index d711bbb..596afa7 100755
--- a/bin/git-changed-in-head
+++ b/bin/git-changed-in-head
@@ -44,4 +44,4 @@
-m \
--first-parent \
--format=format: \
- -- "${PATH_ARGS[@]}" | egrep -v '^$'
+ -- "${PATH_ARGS[@]}" | egrep -v '^$' || : # grep exit 1 when nothing
is found
--
To view, visit https://gerrit.wikimedia.org/r/83435
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib31e89fcaf59df6f8d01f4e785576247dd6cae42
Gerrit-PatchSet: 1
Gerrit-Project: integration/jenkins
Gerrit-Branch: master
Gerrit-Owner: Hashar <has...@free.fr>
Gerrit-Reviewer: Hashar <has...@free.fr>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
