Ori.livneh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/83777


Change subject: StatsD: only report medians to Ganglia
......................................................................

StatsD: only report medians to Ganglia

This patch prevents aggregate figures that aren't median from being reported to
Ganglia. We do care about the other aggregate figures, but they will remain
available in Graphite, and are not vital for rendering the Navigation Timing
view on Ganglia (whereas the medians are).

Change-Id: I7078bf230198f71b11babdd89b331190a8e895bf
---
M manifests/misc/graphite.pp
M modules/statsd/manifests/init.pp
2 files changed, 10 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/77/83777/1

diff --git a/manifests/misc/graphite.pp b/manifests/misc/graphite.pp
index 3a2afb5..90c43f1 100644
--- a/manifests/misc/graphite.pp
+++ b/manifests/misc/graphite.pp
@@ -132,6 +132,11 @@
         notify => Service['navtiming'],
     }
 
+    file { '/usr/local/share/statsd/mediansOnlyFilter.js':
+        contents => 'exports.filter = function ( m ) { return /median$/.test( 
m.name ) && m; };',
+        before   => Service['statsd'],
+    }
+
     file { '/etc/init/navtiming.conf':
         content => template('graphite/modules/navtiming.conf.erb'),
         notify  => Service['navtiming'],
@@ -147,6 +152,7 @@
         graphite_port => 2003,
         settings      => {
             flushInterval    => 5 * 60 * 1000,  # 5 min.
+            gangliaFilters   => [ 
'/usr/local/share/statsd/mediansOnlyFilter.js' ],
             address          => $statsd_host,
             percentThreshold => [ 95 ],
             # Show frequency distribution of client-side latency times.
diff --git a/modules/statsd/manifests/init.pp b/modules/statsd/manifests/init.pp
index 678820a..db397ca 100644
--- a/modules/statsd/manifests/init.pp
+++ b/modules/statsd/manifests/init.pp
@@ -57,6 +57,10 @@
         require => Package['statsd'],
     }
 
+    file { '/usr/local/share/statsd':
+        ensure => directory,
+    }
+
     service { 'statsd':
         ensure   => running,
         provider => upstart,

-- 
To view, visit https://gerrit.wikimedia.org/r/83777
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7078bf230198f71b11babdd89b331190a8e895bf
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ori.livneh <o...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to