Mwalker has submitted this change and it was merged.
Change subject: Always call getKeys for message groups if it exists
......................................................................
Always call getKeys for message groups if it exists
Previously limited only to MessageGroupBase and classes derived
from that.
Bug: 53769
Bug: 53792
Change-Id: I5b065813afaa07699ae68d24659aac4445d59f9f
---
M utils/MessageIndex.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Mwalker: Looks good to me, approved
jenkins-bot: Verified
diff --git a/utils/MessageIndex.php b/utils/MessageIndex.php
index 0b7c442..708da2c 100644
--- a/utils/MessageIndex.php
+++ b/utils/MessageIndex.php
@@ -185,7 +185,7 @@
* @param bool $ignore
*/
protected function checkAndAdd( &$hugearray, MessageGroup $g, $ignore =
false ) {
- if ( $g instanceof MessageGroupBase ) {
+ if ( method_exists( $g, 'getKeys' ) ) {
$keys = $g->getKeys();
} else {
$messages = $g->getDefinitions();
--
To view, visit https://gerrit.wikimedia.org/r/83818
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5b065813afaa07699ae68d24659aac4445d59f9f
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <niklas.laxst...@gmail.com>
Gerrit-Reviewer: Mwalker <mwal...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
