Jgreen has uploaded a new change for review. https://gerrit.wikimedia.org/r/83845
Change subject: minor fixes to otrs idle_agent_report for 2.4->3.2 ...................................................................... minor fixes to otrs idle_agent_report for 2.4->3.2 Change-Id: I7eb2f5559b8406239471486be5d53d80005df876 --- M files/otrs/idle_agent_report 1 file changed, 3 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/45/83845/1 diff --git a/files/otrs/idle_agent_report b/files/otrs/idle_agent_report index 7e69598..b427770 100755 --- a/files/otrs/idle_agent_report +++ b/files/otrs/idle_agent_report @@ -19,7 +19,7 @@ my $rowlimit = 5000; -# http://dev.otrs.org/2.4/Kernel/System/Group.html +# http://dev.otrs.org/3.1/Kernel/System/Group.html # http://meta.wikimedia.org/wiki/OTRS#OTRS_administrators my %RoleOK2View = ( 'OTRS admins' => 1, @@ -73,17 +73,16 @@ # OTRS-authenticated sessions should have a valid Session cookie which returns # UserID etc. We retrieve the cookie and check against OTRS auth API. -# see http://dev.otrs.org/2.4/Kernel/System/AuthSession.html +# see http://dev.otrs.org/3.1/Kernel/System/AuthSession.html # I do not bother to update stored session data for fear of breaking something. my (%SessionData,$RoleAuthOk); my $UserRoles; -my $ClientSessionID = $q->cookie('Session'); +my $ClientSessionID = $q->cookie('OTRSAgentInterface'); if (defined $ClientSessionID) { my $ValidSessionID = $CommonObject{'SessionObject'}->CheckSessionID( 'SessionID' => $ClientSessionID, ); # use SessionData UserID to get Role membership, then check against %RoleOK2View - # there must be a better way but the Group API seems utterly lame and broken if ($ValidSessionID) { %SessionData = $CommonObject{'SessionObject'}->GetSessionIDData( 'SessionID' => $ClientSessionID, -- To view, visit https://gerrit.wikimedia.org/r/83845 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7eb2f5559b8406239471486be5d53d80005df876 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Jgreen <jgr...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
