Chad has uploaded a new change for review.
https://gerrit.wikimedia.org/r/83938
Change subject: Remove dl() usage
......................................................................
Remove dl() usage
dl() was being used in a way that is neither SAPI or platform
indepdendant. Basically, it almost never works reliably so it's
better form to just not use it all.
Change-Id: Ica189caea73319a371c1f0b3ebb5fa6abaa8173f
---
M DatabaseMssqlOld.php
1 file changed, 0 insertions(+), 6 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MSSQLBackCompat
refs/changes/38/83938/1
diff --git a/DatabaseMssqlOld.php b/DatabaseMssqlOld.php
index a36081d..938f0f9 100644
--- a/DatabaseMssqlOld.php
+++ b/DatabaseMssqlOld.php
@@ -64,12 +64,6 @@
function open($server,$user,$password,$dbName) {
wfProfileIn(__METHOD__);
- # Test for missing mysql.so
- # First try to load it
- if (!@extension_loaded('mssql')) {
- @dl('mssql.so');
- }
-
# Fail now
# Otherwise we get a suppressed fatal error, which is very hard
to track down
if (!function_exists( 'mssql_connect')) {
--
To view, visit https://gerrit.wikimedia.org/r/83938
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica189caea73319a371c1f0b3ebb5fa6abaa8173f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MSSQLBackCompat
Gerrit-Branch: master
Gerrit-Owner: Chad <ch...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
