Mooeypoo has uploaded a new change for review.
https://gerrit.wikimedia.org/r/84144
Change subject: [WIP] LanguageBlock Inspector Implementation
......................................................................
[WIP] LanguageBlock Inspector Implementation
This is the implementation of the LanguageBlock node, tool and inspector,
based on the StickeredNode and BlockInspector that are in the dependent
commits.
In this change:
* ve.dm.LanguageBlockNode && ve.ce.LanguageBlockNode - The definition of
the languageblock node as <div> with 'lang' and 'dir' properties.
* ve.ui.LanguageBlockInspector - The behavior of the languageblock inspector
tool is split to two: as an 'add' functionality when called from the main
toolbar, and as an 'edit' functionality when called from the specific node
the button is attached to (through StickerToolbar).
* ve.ui.LanguageBlockAction - The actual 'wrap' and 'unwrap' functionality
for the languageblock nodes. The functionality may end up being elaborate
with several exceptions-to-the-rule (somewhat different behaviro for cases
like list items, table cells, etc) and hence the code is separated from the
inspector itself.
* ve.ce.Node.css - Added visual indication of the languageblock node. This
should probably change to something that looks nicer.
Change-Id: I46b66aaf9f4bd1f8acd1c5aea0883d3146cf42d4
---
M modules/ve/ce/nodes/ve.ce.LanguageBlockNode.js
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/44/84144/1
diff --git a/modules/ve/ce/nodes/ve.ce.LanguageBlockNode.js
b/modules/ve/ce/nodes/ve.ce.LanguageBlockNode.js
index d28c303..a510868 100644
--- a/modules/ve/ce/nodes/ve.ce.LanguageBlockNode.js
+++ b/modules/ve/ce/nodes/ve.ce.LanguageBlockNode.js
@@ -29,7 +29,6 @@
// DOM Changes
this.$.addClass( 've-ce-languageBlockNode' );
-
};
/* Inheritance */
--
To view, visit https://gerrit.wikimedia.org/r/84144
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I46b66aaf9f4bd1f8acd1c5aea0883d3146cf42d4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <mor...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
