Jeroen De Dauw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/84301


Change subject: Use camelCase for method name
......................................................................

Use camelCase for method name

Change-Id: I46cfbb2486630eece63925d07c7d5c4aa4971e78
---
M src/differ/MapDiffer.php
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Diff 
refs/changes/01/84301/1

diff --git a/src/differ/MapDiffer.php b/src/differ/MapDiffer.php
index ca61d04..5e8ece4 100644
--- a/src/differ/MapDiffer.php
+++ b/src/differ/MapDiffer.php
@@ -80,8 +80,8 @@
         * @throws \Exception
         */
        public function doDiff( array $oldValues, array $newValues ) {
-               $newSet = $this->array_diff_assoc( $newValues, $oldValues );
-               $oldSet = $this->array_diff_assoc( $oldValues, $newValues );
+               $newSet = $this->arrayDiffAssoc( $newValues, $oldValues );
+               $oldSet = $this->arrayDiffAssoc( $oldValues, $newValues );
 
                $diffSet = array();
 
@@ -189,7 +189,7 @@
         *
         * @return array
         */
-       protected function array_diff_assoc( array $from, array $to ) {
+       protected function arrayDiffAssoc( array $from, array $to ) {
                $diff = array();
 
                foreach ( $from as $key => $value ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/84301
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I46cfbb2486630eece63925d07c7d5c4aa4971e78
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Diff
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to