jenkins-bot has submitted this change and it was merged. Change subject: Update how VisualEditor's experimental config works ......................................................................
Update how VisualEditor's experimental config works Previously, we used $wmgVisualEditorExperimental to decide whether a wiki would have VisualEditor's "experimental" code enabled for all, or disabled for all. With the forthcoming "BetaFeatures" system, we won't be able to set it in the old way: $wgVisualEditorEnableExperimentalCode = true; … and instead will use a user preference that users can opt-in to pick on a per-user basis. Thus, to set this for all users on a given wiki, we need instead to use: $wgDefaultUserOptions['visualeditor-enable-experimental'] = 1; Change-Id: Id1a977ee8364b0403b5f86c9f0337f17920e1b0d --- M wmf-config/CommonSettings.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Catrope: Looks good to me, approved MarkTraceur: Looks good to me, but someone else must approve Esanders: Looks good to me, but someone else must approve jenkins-bot: Verified diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php index 1884235..a2e483f 100644 --- a/wmf-config/CommonSettings.php +++ b/wmf-config/CommonSettings.php @@ -1910,7 +1910,7 @@ $wgHiddenPrefs[] = 'visualeditor-betatempdisable'; } if ( $wmgVisualEditorExperimental ) { - $wgVisualEditorEnableExperimentalCode = true; + $wgDefaultUserOptions['visualeditor-enable-experimental'] = 1; } // Bug 50000 - to remove once roll-out is complete. if ( $wmgVisualEditorDisableForAnons ) { -- To view, visit https://gerrit.wikimedia.org/r/84433 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1a977ee8364b0403b5f86c9f0337f17920e1b0d Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Jforrester <jforres...@wikimedia.org> Gerrit-Reviewer: Catrope <roan.katt...@gmail.com> Gerrit-Reviewer: Esanders <esand...@wikimedia.org> Gerrit-Reviewer: MarkTraceur <mtrac...@member.fsf.org> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits