CSteipp has uploaded a new change for review. https://gerrit.wikimedia.org/r/84864
Change subject: Remove table from ManageMyGrants list ...................................................................... Remove table from ManageMyGrants list Use <p> instead, to keep things simple Change-Id: I08231162d3295a31cba1304eacab829d06b53b84 --- M frontend/modules/ext.MWOAuth.BasicStyles.css M frontend/specialpages/SpecialMWOAuthManageMyGrants.php 2 files changed, 7 insertions(+), 9 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/OAuth refs/changes/64/84864/1 diff --git a/frontend/modules/ext.MWOAuth.BasicStyles.css b/frontend/modules/ext.MWOAuth.BasicStyles.css index b276eda..f15f6f1 100644 --- a/frontend/modules/ext.MWOAuth.BasicStyles.css +++ b/frontend/modules/ext.MWOAuth.BasicStyles.css @@ -1,10 +1,13 @@ .mw-mwoauthconsumerregistration-body, -.mw-mwoauthmanagemygrants-body, .mw-mwoauthmanageconsumers-body { background-color: #F0F0F0; } +.mw-mwoauthmanagemygrants-list { + +} + .mw-mwoauthmanageconsumers-proposed, .mw-mwoauthmanagemygrants-proposed, .mw-mwoauthconsumerregistration-proposed { diff --git a/frontend/specialpages/SpecialMWOAuthManageMyGrants.php b/frontend/specialpages/SpecialMWOAuthManageMyGrants.php index 4ff223b..c403cf1 100644 --- a/frontend/specialpages/SpecialMWOAuthManageMyGrants.php +++ b/frontend/specialpages/SpecialMWOAuthManageMyGrants.php @@ -273,7 +273,7 @@ return $s . ' [' . $cmr->get( 'version' ) . ']'; } ) ); - $r = "<li>"; + $r = '<li class="mw-mwoauthmanagemygrants-body">'; $r .= "{$encName} (<strong>{$link}</strong>)"; $data = array( 'mwoauthmanagemygrants-user' => $cmr->get( 'userId', @@ -282,15 +282,10 @@ 'MWOAuthUtils::getWikiIdName' ) ); - $r .= "<table class='mw-mwoauthmanagemygrants-body' " . - "cellspacing='1' cellpadding='3' border='1' width='100%'>"; foreach ( $data as $msg => $value ) { - $r .= '<tr>' . - '<td><strong>' . $this->msg( $msg )->escaped() . '</strong></td>' . - '<td width=\'90%\'>' . htmlspecialchars( $value ) . '</td>' . - '</tr>'; + $r .= '<p><strong>' . $this->msg( $msg )->escaped() . '</strong>: ' . + htmlspecialchars( $value ) . '</p>'; } - $r .= '</table>'; $r .= '</li>'; return $r; -- To view, visit https://gerrit.wikimedia.org/r/84864 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I08231162d3295a31cba1304eacab829d06b53b84 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/OAuth Gerrit-Branch: master Gerrit-Owner: CSteipp <cste...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits