Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/85665
Change subject: Don't apply attributes to GC wrapper
......................................................................
Don't apply attributes to GC wrapper
this.$ on a GC node is just a wrapper, so shouldn't take the
HTML attributes from the model, otherwise you may end up with
double borders and padding.
Change-Id: I5641df341c9b118461e7e8fb89266dd300e09755
---
M modules/ve/ce/nodes/ve.ce.GeneratedContentNode.js
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/65/85665/1
diff --git a/modules/ve/ce/nodes/ve.ce.GeneratedContentNode.js
b/modules/ve/ce/nodes/ve.ce.GeneratedContentNode.js
index 4cb0421..fe2bfa4 100644
--- a/modules/ve/ce/nodes/ve.ce.GeneratedContentNode.js
+++ b/modules/ve/ce/nodes/ve.ce.GeneratedContentNode.js
@@ -192,3 +192,5 @@
// TODO: remove 'generating' style
this.generatingPromise = null;
};
+
+ve.ce.GeneratedContentNode.prototype.renderAttributes = function () {};
--
To view, visit https://gerrit.wikimedia.org/r/85665
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5641df341c9b118461e7e8fb89266dd300e09755
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
