jenkins-bot has submitted this change and it was merged. Change subject: Split given statement into several statements ......................................................................
Split given statement into several statements Change-Id: I7f4068bfe52029c20f95f90710e2b69c0e648dec --- M selenium_cuc/features/aliases.feature M selenium_cuc/features/description.feature M selenium_cuc/features/empty_label_and_description.feature M selenium_cuc/features/label.feature M selenium_cuc/features/step_definitions/entity_steps.rb 5 files changed, 16 insertions(+), 5 deletions(-) Approvals: Tobias Gritschacher: Looks good to me, approved jenkins-bot: Verified diff --git a/selenium_cuc/features/aliases.feature b/selenium_cuc/features/aliases.feature index 32c82b3..b4b0fef 100644 --- a/selenium_cuc/features/aliases.feature +++ b/selenium_cuc/features/aliases.feature @@ -10,6 +10,8 @@ Background: Given I am on an item page + And The copyright warning has been dismissed + And Anonymous edit warnings are disabled @ui_only Scenario: Aliases UI has all required elements diff --git a/selenium_cuc/features/description.feature b/selenium_cuc/features/description.feature index b01efdb..72b3354 100644 --- a/selenium_cuc/features/description.feature +++ b/selenium_cuc/features/description.feature @@ -10,6 +10,8 @@ Background: Given I am on an item page + And The copyright warning has been dismissed + And Anonymous edit warnings are disabled @ui_only Scenario: Description UI has all required elements diff --git a/selenium_cuc/features/empty_label_and_description.feature b/selenium_cuc/features/empty_label_and_description.feature index 71869ae..25f1662 100644 --- a/selenium_cuc/features/empty_label_and_description.feature +++ b/selenium_cuc/features/empty_label_and_description.feature @@ -10,6 +10,8 @@ Background: Given I am on an item page with empty label and description + And The copyright warning has been dismissed + And Anonymous edit warnings are disabled @ui_only Scenario: Description UI is shown correctly when description is empty diff --git a/selenium_cuc/features/label.feature b/selenium_cuc/features/label.feature index dd3d4df..5eadeac 100644 --- a/selenium_cuc/features/label.feature +++ b/selenium_cuc/features/label.feature @@ -10,6 +10,8 @@ Background: Given I am on an item page + And The copyright warning has been dismissed + And Anonymous edit warnings are disabled @ui_only Scenario: Label UI has all required elements diff --git a/selenium_cuc/features/step_definitions/entity_steps.rb b/selenium_cuc/features/step_definitions/entity_steps.rb index 2a0c9b4..89b05d0 100644 --- a/selenium_cuc/features/step_definitions/entity_steps.rb +++ b/selenium_cuc/features/step_definitions/entity_steps.rb @@ -10,12 +10,15 @@ item_data = '{"labels":{"en":{"language":"en","value":"' + generate_random_string(8) + '"}},"descriptions":{"en":{"language":"en","value":"' + generate_random_string(20) + '"}}}' item = create_new_entity(item_data, 'item') @entity = item - on(ItemPage) do |page| - page.navigate_to_entity item["url"] - page.set_copyright_ack_cookie - page.set_noanonymouseditwarning_cookie - end + on(ItemPage).navigate_to_entity item["url"] +end +Given /^The copyright warning has been dismissed$/ do + on(ItemPage).set_copyright_ack_cookie +end + +Given /^Anonymous edit warnings are disabled$/ do + on(ItemPage).set_noanonymouseditwarning_cookie end Given /^I am on an item page with empty label and description$/ do -- To view, visit https://gerrit.wikimedia.org/r/85677 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f4068bfe52029c20f95f90710e2b69c0e648dec Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Tobias Gritschacher <tobias.gritschac...@wikimedia.de> Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits