Mattflaschen has submitted this change and it was merged.
Change subject: Fixed a few i18n issues and removed the "id" attribute
......................................................................
Fixed a few i18n issues and removed the "id" attribute
Change-Id: Ib9609095f7250e8243fde49d6372cb9fc0947af5
---
M PronunciationRecording.i18n.php
M SpecialPronunciationRecording.php
M resources/ext.pronunciationRecording.specialPage.js
3 files changed, 10 insertions(+), 10 deletions(-)
Approvals:
Mattflaschen: Verified; Looks good to me, approved
diff --git a/PronunciationRecording.i18n.php b/PronunciationRecording.i18n.php
index 8c03525..cffba0a 100644
--- a/PronunciationRecording.i18n.php
+++ b/PronunciationRecording.i18n.php
@@ -21,16 +21,15 @@
'pronunciationrecording-toolbar-upload-label' => 'Upload',
'pronunciationrecording-webaudio-not-supported' => 'WebAudio API is not
supported for this browser',
'pronunciationrecording-specialpage-error-nologin' => 'You must be [$1
logged in] to record and upload pronunciations.',
- 'pronunciationrecording-upload-publish-succeeded' => 'Recording
uploaded successfully: ',
+ 'pronunciationrecording-upload-publish-succeeded' => 'Recording
uploaded successfully:',
'pronunciationrecording-upload-publish-failed' => 'Recording was not
uploaded',
'pronunciationrecording-information-label' => 'Information',
'pronunciationrecording-information-word-label' => 'Word:',
'pronunciationrecording-information-language-label' => 'Language:',
'pronunciationrecording-mic-access-notify' => 'Click "Allow" to allow
the browser to access your microphone.',
- 'pronunciationrecording-recording-notify' => 'Recording....',
+ 'pronunciationrecording-recording-notify' => 'Recording...',
'pronunciationrecording-information-license-prompt' => 'By using
PronunciationRecording and clicking
{{int:pronunciationrecording-toolbar-upload-label}}, {{GENDER:$1|you}} agree to
the following terms for your recording:',
);
-
/** Message documentation (Message documentation)
* @author Shirayuki
diff --git a/SpecialPronunciationRecording.php
b/SpecialPronunciationRecording.php
index e4c3e33..c7e306a 100644
--- a/SpecialPronunciationRecording.php
+++ b/SpecialPronunciationRecording.php
@@ -21,12 +21,12 @@
}
$output->addModules(
'ext.pronunciationRecording.specialPage' );
- $output->addHTML( '<div
class="mw-pronunciationrecording-message"
id="mw-pronunciationrecording-message"></div>' );
- $output->addHTML( '<div
class="mw-pronunciationrecording-toolbar"
id="mw-pronunciationrecording-toolbar" >' );
- $output->addHTML( '<button
class="mw-pronunciationrecording-record" id="mw-pronunciationrecording-record"
disabled>' .wfMessage( 'pronunciationrecording-toolbar-record-label'
)->escaped().'</button>' );
- $output->addHTML( '<button
class="mw-pronunciationrecording-stop" id="mw-pronunciationrecording-stop"
disabled >' .wfMessage( 'pronunciationrecording-toolbar-stop-label'
)->escaped().'</button>' );
- $output->addHTML( '<button
class="mw-pronunciationrecording-clear" id="mw-pronunciationrecording-clear"
disabled >' .wfMessage( 'pronunciationrecording-toolbar-clear-label'
)->escaped().'</button>' );
- $output->addHTML( '<div
class="mw-pronunciationrecording-preview-div"
id="mw-pronunciationrecording-preview-div" disabled ></div>' );
+ $output->addHTML( '<div
class="mw-pronunciationrecording-message" ></div>' );
+ $output->addHTML( '<div
class="mw-pronunciationrecording-toolbar" >' );
+ $output->addHTML( '<button
class="mw-pronunciationrecording-record" disabled >' .wfMessage(
'pronunciationrecording-toolbar-record-label' )->escaped().'</button>' );
+ $output->addHTML( '<button
class="mw-pronunciationrecording-stop" disabled >' .wfMessage(
'pronunciationrecording-toolbar-stop-label' )->escaped().'</button>' );
+ $output->addHTML( '<button
class="mw-pronunciationrecording-clear" disabled >' .wfMessage(
'pronunciationrecording-toolbar-clear-label' )->escaped().'</button>' );
+ $output->addHTML( '<div
class="mw-pronunciationrecording-preview-div" ></div>' );
$output->addHTML( '</div>' );
$output->addHTML( '<form>' );
$output->addHTML( '<fieldset>' );
@@ -39,7 +39,7 @@
}
$output->addHTML( '</select>' );
$output->addHTML( '<br><br>'.wfMessage(
'pronunciationrecording-information-license-prompt', $user )->escaped() );
- $output->addHTML( '<div class =
"mw-pronunciationrecording-information-license-cc-by-sa" >'.wfMessage(
'mwe-upwiz-source-ownwork-assert-cc-by-sa-3.0', 1, $user,
'http://creativecommons.org/licenses/by-sa/3.0/deed.en' )->parse().'<br>' );
+ $output->addHTML( '<div
class="mw-pronunciationrecording-information-license-cc-by-sa" >'.wfMessage(
'mwe-upwiz-source-ownwork-assert-cc-by-sa-3.0', 1, $user,
'http://creativecommons.org/licenses/by-sa/3.0/deed.en' )->parse().'<br>' );
$output->addHTML( wfMessage(
'mwe-upwiz-source-ownwork-cc-by-sa-3.0-explain', 1 )->escaped().'<br></div>' );
$output->addHTML( '</fieldset>' );
$output->addHTML( '</form>' );
diff --git a/resources/ext.pronunciationRecording.specialPage.js
b/resources/ext.pronunciationRecording.specialPage.js
index a17536f..4e5d991 100644
--- a/resources/ext.pronunciationRecording.specialPage.js
+++ b/resources/ext.pronunciationRecording.specialPage.js
@@ -36,6 +36,7 @@
$fileLink.attr( "href",
mw.util.wikiGetlink( name ) );
$fileLink.text( name );
$( ".mw-pronunciationrecording-message"
).text( mw.message( 'pronunciationrecording-upload-publish-succeeded' ).text()
);
+ $( ".mw-pronunciationrecording-message"
).append( " " );
$( ".mw-pronunciationrecording-message"
).append( $fileLink );
}, function() {
$( ".mw-pronunciationrecording-message"
).text( mw.message( 'pronunciationrecording-upload-publish-failed' ).text() );
--
To view, visit https://gerrit.wikimedia.org/r/85686
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9609095f7250e8243fde49d6372cb9fc0947af5
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/PronunciationRecording
Gerrit-Branch: master
Gerrit-Owner: Rahul21 <rahul14...@gmail.com>
Gerrit-Reviewer: Mattflaschen <mflasc...@wikimedia.org>
Gerrit-Reviewer: Mdale <md...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
