Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/86053
Change subject: Update schema; remove 'mobileTargets'. ...................................................................... Update schema; remove 'mobileTargets'. The version of NavigationTiming that is currently deployed computes a set of Navigation Timing intervals that represent a small subset of the intervals that are potentially interesting to us. A more flexible approach is to simply log the value of each interesting marker relative to NavigationStart, and derive interval measurements on the server. This patch updates NavigationTiming to revision 5832704 of <https://meta.wikimedia.org/wiki/Schema:NavigationTiming>. The data points that are collected reflect my experiments with the Navigation Timing API, documented at <https://wikitech.wikimedia.org/wiki/Navigation_Timing>. Also removes obsolete 'mobileTargets' property on module declarations. Change-Id: Ib43387e72ea309f547d5cd4fc52f24cead0e6305 --- M NavigationTiming.php M modules/ext.navigationTiming.js 2 files changed, 20 insertions(+), 14 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/NavigationTiming refs/changes/53/86053/1 diff --git a/NavigationTiming.php b/NavigationTiming.php index 9064c8f..2f0a687 100644 --- a/NavigationTiming.php +++ b/NavigationTiming.php @@ -35,9 +35,8 @@ 'schema.NavigationTiming' => array( 'class' => 'ResourceLoaderSchemaModule', 'schema' => 'NavigationTiming', - 'revision' => 5336845, + 'revision' => 5832704, 'targets' => array( 'desktop', 'mobile' ), - 'mobileTargets' => array( 'stable', 'beta', 'alpha' ), ), 'ext.navigationTiming' => array( 'scripts' => 'ext.navigationTiming.js', @@ -45,7 +44,6 @@ 'remoteExtPath' => 'NavigationTiming/modules', 'dependencies' => 'schema.NavigationTiming', 'targets' => array( 'desktop', 'mobile' ), - 'mobileTargets' => array( 'stable', 'beta', 'alpha' ), ) ); diff --git a/modules/ext.navigationTiming.js b/modules/ext.navigationTiming.js index 873a42a..031eb65 100644 --- a/modules/ext.navigationTiming.js +++ b/modules/ext.navigationTiming.js @@ -65,20 +65,28 @@ event.originCountry = Geo.country; } - $.each( { - dnsLookup : timing.domainLookupEnd - timing.domainLookupStart, - connecting : timing.connectEnd - timing.connectStart, - sending : timing.fetchStart - navStart, - waiting : timing.responseStart - timing.requestStart, - receiving : timing.responseEnd - timing.responseStart, - rendering : timing.loadEventEnd - timing.responseEnd, - loading : timing.loadEventStart - navStart - }, function ( k, v ) { - if ( $.isNumeric( v ) && v > 0 ) { - event[ k ] = v; + [ + 'connectEnd', + 'connectStart', + 'domComplete', + 'domInteractive', + 'fetchStart', + 'loadEventEnd', + 'loadEventStart', + 'requestStart', + 'responseEnd', + 'responseStart' + ].forEach( function ( marker ) { + var measure = timing[marker] - navStart; + if ( $.isNumeric( measure ) && measure > 0 ) { + event[ marker ] = measure; } } ); + if ( timing.domainLookupStart ) { + event.dnsLookup = timing.domainLookupEnd - timing.domainLookupStart; + } + if ( timing.redirectStart ) { event.redirectCount = performance.navigation.redirectCount; event.redirecting = timing.redirectEnd - timing.redirectStart; -- To view, visit https://gerrit.wikimedia.org/r/86053 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib43387e72ea309f547d5cd4fc52f24cead0e6305 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/NavigationTiming Gerrit-Branch: master Gerrit-Owner: Ori.livneh <o...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
