jenkins-bot has submitted this change and it was merged.
Change subject: Use $.each instead of [].forEach to avoid distracting reviewers
......................................................................
Use $.each instead of [].forEach to avoid distracting reviewers
It's fine to use forEach here, but between forEach + comment & just using
$.each, I'd prefer the latter.
Change-Id: I5c4ecca9878f40afa476f5425afce035487973fb
---
M modules/ext.navigationTiming.js
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Ori.livneh: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ext.navigationTiming.js b/modules/ext.navigationTiming.js
index 7c57e6c..f17f4bf 100644
--- a/modules/ext.navigationTiming.js
+++ b/modules/ext.navigationTiming.js
@@ -65,8 +65,7 @@
event.originCountry = Geo.country;
}
- // Note: This assumes if a browser is good enough to support
window.performance it supports forEach
- [
+ $.each( [
'connectEnd',
'connectStart',
'domComplete',
@@ -77,7 +76,7 @@
'requestStart',
'responseEnd',
'responseStart'
- ].forEach( function ( marker ) {
+ ], function ( _, marker ) {
var measure = timing[marker] - navStart;
if ( $.isNumeric( measure ) && measure > 0 ) {
event[ marker ] = measure;
--
To view, visit https://gerrit.wikimedia.org/r/86189
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5c4ecca9878f40afa476f5425afce035487973fb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/NavigationTiming
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
