Brion VIBBER has uploaded a new change for review.
https://gerrit.wikimedia.org/r/86327
Change subject: Fix media URL generation for non-ASCII filenames
......................................................................
Fix media URL generation for non-ASCII filenames
Characters in the filename weren't being encoded when generating
a URL, which seems to break something in the network fetching.
Change-Id: I10a18d1e5e32a4806cdae03b4a510a18eba9802b
---
M commons/src/main/java/org/wikimedia/commons/Utils.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/commons
refs/changes/27/86327/1
diff --git a/commons/src/main/java/org/wikimedia/commons/Utils.java
b/commons/src/main/java/org/wikimedia/commons/Utils.java
index f3bea5a..49868d5 100644
--- a/commons/src/main/java/org/wikimedia/commons/Utils.java
+++ b/commons/src/main/java/org/wikimedia/commons/Utils.java
@@ -38,7 +38,7 @@
public static String makeThumbBaseUrl(String filename) {
String name = filename.replaceFirst("File:", "").replace(" ", "_");
String sha = new String(Hex.encodeHex(DigestUtils.md5(name)));
- return String.format("%s/%s/%s/%s", CommonsApplication.IMAGE_URL_BASE,
sha.substring(0, 1), sha.substring(0, 2), name);
+ return String.format("%s/%s/%s/%s", CommonsApplication.IMAGE_URL_BASE,
sha.substring(0, 1), sha.substring(0, 2), urlEncode(name));
}
--
To view, visit https://gerrit.wikimedia.org/r/86327
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I10a18d1e5e32a4806cdae03b4a510a18eba9802b
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/commons
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER <br...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
