Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/86669
Change subject: Fix comma errors in various js files (new jshint warning)
......................................................................
Fix comma errors in various js files (new jshint warning)
We're about to upgrade to JSHint 2.x. Among various improvements
it now properly detects incorrect use of the comma operator.
This helped uncover two mistakes that could solve a bug, though
in this case the difference was purely in the semantics. The
endresult is unchanged.
Incorrect use of the comma operator can lead to assigning the
wrong value to a variable or causing an implied global variable.
Change-Id: I6fdae5f66ef69b6526121cd7b1b2fbb0d9df7a62
---
M resources/jquery/jquery.textSelection.js
M tests/qunit/suites/resources/mediawiki/mediawiki.util.test.js
2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/69/86669/1
diff --git a/resources/jquery/jquery.textSelection.js
b/resources/jquery/jquery.textSelection.js
index c44816b..2b5a440 100644
--- a/resources/jquery/jquery.textSelection.js
+++ b/resources/jquery/jquery.textSelection.js
@@ -293,7 +293,7 @@
postFinished = false;
periRange =
document.selection.createRange().duplicate();
- preRange = rangeForElementIE( e
),
+ preRange = rangeForElementIE( e
);
// Move the end where we need it
preRange.setEndPoint(
'EndToStart', periRange );
diff --git a/tests/qunit/suites/resources/mediawiki/mediawiki.util.test.js
b/tests/qunit/suites/resources/mediawiki/mediawiki.util.test.js
index f2676d7d..08adb93 100644
--- a/tests/qunit/suites/resources/mediawiki/mediawiki.util.test.js
+++ b/tests/qunit/suites/resources/mediawiki/mediawiki.util.test.js
@@ -95,8 +95,8 @@
'</div>' +
'<ul><li></li></ul>' +
'</div>';
- $( tocHtml ).appendTo( '#qunit-fixture' ),
- $toggleLink = $( '#togglelink' );
+ $( tocHtml ).appendTo( '#qunit-fixture' );
+ $toggleLink = $( '#togglelink' );
assert.strictEqual( $toggleLink.length, 1, 'Toggle link is
appended to the page.' );
--
To view, visit https://gerrit.wikimedia.org/r/86669
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6fdae5f66ef69b6526121cd7b1b2fbb0d9df7a62
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <krinklem...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
