jenkins-bot has submitted this change and it was merged. Change subject: Fix for IME menu integration tests ......................................................................
Fix for IME menu integration tests Make sure to click only when Input Method indicator is available. Change-Id: Ieff61d74a8ea5b8bcb7aafdc94865dee4927dc97 --- M tests/browser/features/step_definitions/ime_steps.rb 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Zfilipin: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/browser/features/step_definitions/ime_steps.rb b/tests/browser/features/step_definitions/ime_steps.rb index 725c9f7..384487f 100644 --- a/tests/browser/features/step_definitions/ime_steps.rb +++ b/tests/browser/features/step_definitions/ime_steps.rb @@ -16,7 +16,7 @@ end When(/^I click on the input method indicator$/) do - on(RandomPage).input_method_element.click + on(RandomPage).input_method_element.when_present.click end When(/^I open the input method menu$/) do @@ -28,7 +28,7 @@ end Then(/^I should see the input method indicator$/) do - on(RandomPage).input_method_element.should be_visible + on(RandomPage).input_method_element.when_present.should be_visible end Then(/^I should see input methods for (.+)/) do |language| -- To view, visit https://gerrit.wikimedia.org/r/86680 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieff61d74a8ea5b8bcb7aafdc94865dee4927dc97 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: KartikMistry <kartik.mis...@gmail.com> Gerrit-Reviewer: Amire80 <amir.ahar...@mail.huji.ac.il> Gerrit-Reviewer: Arrbee <run...@gmail.com> Gerrit-Reviewer: KartikMistry <kartik.mis...@gmail.com> Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com> Gerrit-Reviewer: SuchetaG <sucheta.ghos...@gmail.com> Gerrit-Reviewer: Zfilipin <zfili...@wikimedia.org> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
