jenkins-bot has submitted this change and it was merged.
Change subject: Fixes incorrectly declared GraphViz graphsize parameter.
......................................................................
Fixes incorrectly declared GraphViz graphsize parameter.
It's been wrong for at least a year and reported at least twice (#40088,
#35868).
Change-Id: I7f70d2e8a2bb9a478c816194af39fa3ffa1ecccf
---
M formats/graphviz/SRF_Graph.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Nathan Douglas: Looks good to me, but someone else must approve
Mwjames: Looks good to me, approved
jenkins-bot: Verified
diff --git a/formats/graphviz/SRF_Graph.php b/formats/graphviz/SRF_Graph.php
index c56ce9c..9b30f66 100644
--- a/formats/graphviz/SRF_Graph.php
+++ b/formats/graphviz/SRF_Graph.php
@@ -293,7 +293,7 @@
);
$params['graphsize'] = array(
- 'type' => 'integer',
+ 'type' => 'string',
'default' => '',
'message' => 'srf_paramdesc_graphsize',
'manipulatedefault' => false,
--
To view, visit https://gerrit.wikimedia.org/r/85922
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f70d2e8a2bb9a478c816194af39fa3ffa1ecccf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticResultFormats
Gerrit-Branch: master
Gerrit-Owner: Nathan Douglas <s...@thedouglasfamily.org>
Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com>
Gerrit-Reviewer: Mwjames <jamesin.hongkon...@gmail.com>
Gerrit-Reviewer: Nathan Douglas <s...@thedouglasfamily.org>
Gerrit-Reviewer: Yaron Koren <yaro...@gmail.com>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
