jenkins-bot has submitted this change and it was merged.
Change subject: Tests for programmer friendly word splitting.
......................................................................
Tests for programmer friendly word splitting.
Bug: 54799
Change-Id: I7bbe0152095af982a1b929f8f7ae2445cbe698fc
---
M tests/browser/features/full_text.feature
M tests/browser/features/full_text_advanced.feature
M tests/browser/features/full_text_highlighting.feature
M tests/browser/features/support/build_pages.rb
4 files changed, 38 insertions(+), 3 deletions(-)
Approvals:
Chad: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/browser/features/full_text.feature
b/tests/browser/features/full_text.feature
index edb71e0..74bcdaa 100644
--- a/tests/browser/features/full_text.feature
+++ b/tests/browser/features/full_text.feature
@@ -35,8 +35,7 @@
| File:Savepage-greyed.png | File:Savepage-greyed.png is
| not in | image |
| File:Savepage | File:Savepage-greyed.png is
| not in | image |
| File:greyed.png | File:Savepage-greyed.png is
| not in | image |
- # Bug 52948
- #| File:greyed | File:Savepage-greyed.png is
| not in | image |
+ | File:greyed | File:Savepage-greyed.png is
| not in | image |
| File:"Screenshot, for test purposes" | File:Savepage-greyed.png is
| not in | image |
# You can't search for text inside a <video> or <audio> tag
| "JavaScript disabled" | none is
| not in | |
@@ -269,3 +268,23 @@
Scenario: Searching for a quoted * actually searches for a *
When I search for "pick*"
Then Pick* is the first search result
+
+ @programmer_friendly
+ Scenario Outline: Programmer friendly searches
+ When I search for <term>
+ Then <page> is the first search result
+ Examples:
+ | term | page |
+ | namespace aliases | $wgNamespaceAliases |
+ | namespaceAliases | $wgNamespaceAliases |
+ | $wgNamespaceAliases | $wgNamespaceAliases |
+ | namespace_aliases | $wgNamespaceAliases |
+ | NamespaceAliases | $wgNamespaceAliases |
+ | snake case | PFSC |
+ | snakeCase | PFSC |
+ | snake_case | PFSC |
+ | SnakeCase | PFSC |
+ | Pascal Case | PascalCase |
+ | pascalCase | PascalCase |
+ | pascal_case | PascalCase |
+ | PascalCase | PascalCase |
diff --git a/tests/browser/features/full_text_advanced.feature
b/tests/browser/features/full_text_advanced.feature
index 19fe019..092767b 100644
--- a/tests/browser/features/full_text_advanced.feature
+++ b/tests/browser/features/full_text_advanced.feature
@@ -38,4 +38,4 @@
| Talk, Help | catapult | Talk:Two Words is |
| Help, Help talk | catapult | none is |
| (Main) or (Article) | catapult | Catapult is in |
- | List redirects | rdir | none is |
+ | List redirects | "rdir" | none is |
diff --git a/tests/browser/features/full_text_highlighting.feature
b/tests/browser/features/full_text_highlighting.feature
index 37a45c8..b25f7fa 100644
--- a/tests/browser/features/full_text_highlighting.feature
+++ b/tests/browser/features/full_text_highlighting.feature
@@ -60,3 +60,8 @@
Scenario: The highest scoring redirect is highlighted
When I search for crazy rdir
Then *Crazy* *Rdir* is the highlighted alttitle of the first search result
+
+ @programmer_friendly
+ Scenario: camelCase is highlighted correctly
+ When I search for namespace aliases
+ Then $wg*Namespace**Aliases* is the highlighted title of the first search
result
diff --git a/tests/browser/features/support/build_pages.rb
b/tests/browser/features/support/build_pages.rb
index c755109..4626eaa 100644
--- a/tests/browser/features/support/build_pages.rb
+++ b/tests/browser/features/support/build_pages.rb
@@ -139,3 +139,14 @@
end
$exact_quotes = true
end
+
+Before('@programmer_friendly') do
+ if !$programmer_friendly
+ steps %Q{
+ Given a page named $wgNamespaceAliases exists
+ And a page named PFSC exists with contents snake_case
+ And a page named PascalCase exists
+ }
+ $programmer_friendly = true
+ end
+end
--
To view, visit https://gerrit.wikimedia.org/r/86782
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7bbe0152095af982a1b929f8f7ae2445cbe698fc
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/CirrusSearch
Gerrit-Branch: master
Gerrit-Owner: Manybubbles <never...@wikimedia.org>
Gerrit-Reviewer: Chad <ch...@wikimedia.org>
Gerrit-Reviewer: Cmcmahon <cmcma...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
