Zfilipin has submitted this change and it was merged.
Change subject: id changed for searchButton in master; also had bogus step
......................................................................
id changed for searchButton in master; also had bogus step
Change-Id: Id77fe9b9f9a2bfd1e2330ca27883bef863614176
---
M features/search.feature
M features/support/pages/random_page.rb
M features/support/pages/search_page.rb
3 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Manybubbles: Looks good to me, approved
Zfilipin: Looks good to me, approved
jenkins-bot: Verified
diff --git a/features/search.feature b/features/search.feature
index 63140c8..b5e2b8d 100644
--- a/features/search.feature
+++ b/features/search.feature
@@ -14,6 +14,6 @@
Then I should land on Search Results page
Scenario: Search with accent yields result page with accent
- Given I visit a random page
+ Given I am at random page
When I search for África
Then the page I arrive on has title África
diff --git a/features/support/pages/random_page.rb
b/features/support/pages/random_page.rb
index fe0ebae..cc97b08 100644
--- a/features/support/pages/random_page.rb
+++ b/features/support/pages/random_page.rb
@@ -20,7 +20,7 @@
a(:print_export, text: 'Print/export')
a(:printable_version, text: 'Printable version')
li(:uls_malayalam_inscript2_item, data_ime_inputmethod: 'ml-inscript2')
- button(:search_button, id: 'searchButton')
+ button(:search_button, id: 'mw-searchButton')
text_field(:search_input, id: 'searchInput')
a(:uls_trigger, class: 'uls-trigger')
end
diff --git a/features/support/pages/search_page.rb
b/features/support/pages/search_page.rb
index 2d1fd83..6a4fc4a 100644
--- a/features/support/pages/search_page.rb
+++ b/features/support/pages/search_page.rb
@@ -2,7 +2,7 @@
include PageObject
div(:one_result, class: 'suggestions-result')
- button(:search_button, id: 'searchButton')
+ button(:search_button, id: 'mw-searchButton')
text_field(:search_input, id: 'searchInput')
div(:search_results, class: 'suggestions-results')
end
--
To view, visit https://gerrit.wikimedia.org/r/87292
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id77fe9b9f9a2bfd1e2330ca27883bef863614176
Gerrit-PatchSet: 2
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon <cmcma...@wikimedia.org>
Gerrit-Reviewer: Manybubbles <never...@wikimedia.org>
Gerrit-Reviewer: Zfilipin <zfili...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
