Addshore has submitted this change and it was merged.
Change subject: Remove TODOs that are not needed
......................................................................
Remove TODOs that are not needed
Change-Id: Ica755eba23d05d53c6b134d740ce4c696bde76c1
---
M src/MySQL/MySQLSchemaSqlBuilder.php
M src/SQLite/SQLiteSchemaSqlBuilder.php
M src/Schema/SchemaModificationSqlBuilder.php
M src/Schema/SchemaModifier.php
4 files changed, 0 insertions(+), 8 deletions(-)
Approvals:
Addshore: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/MySQL/MySQLSchemaSqlBuilder.php
b/src/MySQL/MySQLSchemaSqlBuilder.php
index 1299552..7b96c3a 100644
--- a/src/MySQL/MySQLSchemaSqlBuilder.php
+++ b/src/MySQL/MySQLSchemaSqlBuilder.php
@@ -48,6 +48,4 @@
return "ALTER TABLE {$tableName} ADD " .
$this->fieldSqlBuilder->getFieldSQL( $field );
}
- // TODO: add other methods
-
}
diff --git a/src/SQLite/SQLiteSchemaSqlBuilder.php
b/src/SQLite/SQLiteSchemaSqlBuilder.php
index 992c13a..942548b 100644
--- a/src/SQLite/SQLiteSchemaSqlBuilder.php
+++ b/src/SQLite/SQLiteSchemaSqlBuilder.php
@@ -76,6 +76,4 @@
return "ALTER TABLE {$tableName} ADD COLUMN " .
$this->fieldSqlBuilder->getFieldSQL( $field );
}
- // TODO: add other methods
-
}
diff --git a/src/Schema/SchemaModificationSqlBuilder.php
b/src/Schema/SchemaModificationSqlBuilder.php
index 91fae61..91aa902 100644
--- a/src/Schema/SchemaModificationSqlBuilder.php
+++ b/src/Schema/SchemaModificationSqlBuilder.php
@@ -27,6 +27,4 @@
*/
public function getAddFieldSql( $tableName, FieldDefinition $field );
- // TODO: add other methods
-
}
diff --git a/src/Schema/SchemaModifier.php b/src/Schema/SchemaModifier.php
index 2eb4b70..d2d3385 100644
--- a/src/Schema/SchemaModifier.php
+++ b/src/Schema/SchemaModifier.php
@@ -27,6 +27,4 @@
*/
public function addField( $tableName, FieldDefinition $field );
- // TODO: add other methods
-
}
--
To view, visit https://gerrit.wikimedia.org/r/87553
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ica755eba23d05d53c6b134d740ce4c696bde76c1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseDatabase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
