Addshore has uploaded a new change for review.
https://gerrit.wikimedia.org/r/87566
Change subject: Remove TODOs for options
......................................................................
Remove TODOs for options
No need to add this functionality yet
Change-Id: Iba274971595dcb63b09d0030a933838a568376f9
---
M src/MySQL/MySQLTableSqlBuilder.php
M src/SQLite/SQLiteTableSqlBuilder.php
2 files changed, 0 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseDatabase
refs/changes/66/87566/1
diff --git a/src/MySQL/MySQLTableSqlBuilder.php
b/src/MySQL/MySQLTableSqlBuilder.php
index c1ae2ab..db68c30 100644
--- a/src/MySQL/MySQLTableSqlBuilder.php
+++ b/src/MySQL/MySQLTableSqlBuilder.php
@@ -63,7 +63,6 @@
$sql .= implode( ', ', $queryParts );
- // TODO: table options
$sql .= ') ' . 'ENGINE=InnoDB, DEFAULT CHARSET=binary';
return $sql;
diff --git a/src/SQLite/SQLiteTableSqlBuilder.php
b/src/SQLite/SQLiteTableSqlBuilder.php
index c190b1b..1c38c61 100644
--- a/src/SQLite/SQLiteTableSqlBuilder.php
+++ b/src/SQLite/SQLiteTableSqlBuilder.php
@@ -56,7 +56,6 @@
$sql .= implode( ', ', $fields );
- // TODO: table options
$sql .= ');';
foreach ( $table->getIndexes() as $index ){
--
To view, visit https://gerrit.wikimedia.org/r/87566
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iba274971595dcb63b09d0030a933838a568376f9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseDatabase
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
