[MediaWiki-commits] [Gerrit] Update store setup and teardown in EntitiesByPropertyValueAp... - change (mediawiki...WikibaseQuery)

[Jeroen De Dauw (Code Review)]

Jeroen De Dauw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88035


Change subject: Update store setup and teardown in 
EntitiesByPropertyValueApiTest
......................................................................

Update store setup and teardown in EntitiesByPropertyValueApiTest

Change-Id: Ibab0bb678526eb1ed8565ec587e693a2828cc9f0
---
M Tests/System/Wikibase/Query/EntitiesByPropertyValueApiTest.php
1 file changed, 2 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQuery 
refs/changes/35/88035/1

diff --git a/Tests/System/Wikibase/Query/EntitiesByPropertyValueApiTest.php 
b/Tests/System/Wikibase/Query/EntitiesByPropertyValueApiTest.php
index c8e8e54..82763db 100644
--- a/Tests/System/Wikibase/Query/EntitiesByPropertyValueApiTest.php
+++ b/Tests/System/Wikibase/Query/EntitiesByPropertyValueApiTest.php
@@ -36,28 +36,20 @@
                return ExtensionAccess::getWikibaseQuery()->getQueryStore();
        }
 
-       protected function reinitializeStore() {
-               $queryStore = $this->getQueryStore();
-               $setup = $queryStore->newSetup();
-
-               $setup->uninstall();
-               $setup->install();
-       }
-
        public function setUp() {
                parent::setUp();
 
                $this->itemId = new ItemId( self::ITEM_ID_STRING );
                $this->propertyId = new PropertyId( self::PROPERTY_ID_STRING );
 
-               $this->reinitializeStore();
+               $this->getQueryStore()->newSetup()->install();
 
                $this->createNewProperty();
                $this->insertNewItem();
        }
 
        public function tearDown() {
-               $this->reinitializeStore();
+               $this->getQueryStore()->newSetup()->uninstall();
                parent::tearDown();
        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/88035
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibab0bb678526eb1ed8565ec587e693a2828cc9f0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQuery
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits