Tobias Gritschacher has uploaded a new change for review.
https://gerrit.wikimedia.org/r/88454
Change subject: Fixed link to Special:SetSiteLink in ItemView - again
......................................................................
Fixed link to Special:SetSiteLink in ItemView - again
- this broke in I430dc1f2bde36ee3f8c94ef846a54ebd80fc21f2
Change-Id: If747fc5dbd0ef942598c5d13fdecf34bb3bf09e1
---
M repo/includes/EntityView.php
M repo/includes/ItemView.php
2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/54/88454/1
diff --git a/repo/includes/EntityView.php b/repo/includes/EntityView.php
index 19219f2..154992f 100644
--- a/repo/includes/EntityView.php
+++ b/repo/includes/EntityView.php
@@ -737,11 +737,11 @@
*
* @param string $specialpagename
* @param Entity $entity
- * @param \Language $lang
+ * @param \Language $lang|null
*
* @return string
*/
- protected function getEditUrl( $specialpagename, Entity $entity,
Language $lang ) {
+ protected function getEditUrl( $specialpagename, Entity $entity,
Language $lang = null ) {
$specialpage = \SpecialPageFactory::getPage( $specialpagename );
if ( $specialpage === null ) {
diff --git a/repo/includes/ItemView.php b/repo/includes/ItemView.php
index a9184ce..ee8b9d4 100644
--- a/repo/includes/ItemView.php
+++ b/repo/includes/ItemView.php
@@ -121,7 +121,7 @@
}
// Link to SpecialPage
- $editLink = $this->getEditUrl( 'SetSiteLink', $item, $lang );
+ $editLink = $this->getEditUrl( 'SetSiteLink', $item, null );
/* @var SiteLink $link */
foreach( $siteLinks as $link ) {
--
To view, visit https://gerrit.wikimedia.org/r/88454
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If747fc5dbd0ef942598c5d13fdecf34bb3bf09e1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
