Nikerabbit has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88693


Change subject: Stash: load in correct language and minor refactoring
......................................................................

Stash: load in correct language and minor refactoring

Change-Id: Ifd9e6c757edaae8613ae4be23d07bd3cc9995008
---
M resources/js/ext.translate.special.translationstash.js
1 file changed, 21 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/93/88693/1

diff --git a/resources/js/ext.translate.special.translationstash.js 
b/resources/js/ext.translate.special.translationstash.js
index 7327fda..46030f6 100644
--- a/resources/js/ext.translate.special.translationstash.js
+++ b/resources/js/ext.translate.special.translationstash.js
@@ -19,8 +19,10 @@
                        mclanguage: language,
                        mcoffset: offset,
                        mclimit: limit,
-                       mcprop: 'definition|translation|tags|properties'
+                       mcprop: 'definition|properties'
                } );
+
+               // @todo: We need to get translations from the stash api
        }
 
        function addMessage( message ) {
@@ -92,7 +94,7 @@
                var $messageTable = $( '.tux-messagelist' ),
                        messagegroup = '!sandbox';
 
-               getMessages( messagegroup, $messageTable.data( 'targetLang' ), 
0, 5 )
+               getMessages( messagegroup, $messageTable.data( 'targetlangcode' 
), 0, 20 )
                        .done( function ( result ) {
                                var messages = result.query.messagecollection;
                                $.each( messages, function ( index, message ) {
@@ -110,18 +112,28 @@
        }
 
        $( 'document' ).ready( function () {
-               var $messageTable = $( '.tux-messagelist' );
+               var $messageTable = $( '.tux-messagelist' ),
+                       $ulsTrigger = $( '.ext-translate-language-selector > 
.uls' );
 
-               $( '.ext-translate-language-selector .uls' ).uls( {
+               $ulsTrigger.uls( {
                        onSelect: function ( language ) {
-                               $( '.ext-translate-language-selector > .uls' )
-                                       .text( $.uls.data.getAutonym( language 
) )
+                               var direction = $.uls.data.getDir( language ),
+                                       autonym = $.uls.data.getAutonym( 
language );
+
+                               $ulsTrigger
+                                       .text( autonym )
                                        .attr( {
                                                lang: language,
-                                               dir: $.uls.data.getDir( 
language )
+                                               dir: direction
                                        } );
-                               $messageTable.empty();
-                               $messageTable.data( 'targetLang', language );
+
+                               $messageTable
+                                       .empty()
+                                       .data( {
+                                               targetlangcode: language,
+                                               targetlangdir: direction
+                                       } );
+
                                loadMessages();
                        }
                } );

-- 
To view, visit https://gerrit.wikimedia.org/r/88693
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd9e6c757edaae8613ae4be23d07bd3cc9995008
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <niklas.laxst...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to