Rfaulk has submitted this change and it was merged.

Change subject: mod - 1. remove obsolete tests. \n2. Add some setup to existing 
tests.
......................................................................


mod - 1. remove obsolete tests. \n2. Add some setup to existing tests.

Change-Id: I5ceee8da7e106b2b70e404ec10b4ef7eef97b4ec
---
M sartoris/tests/test.py
1 file changed, 3 insertions(+), 18 deletions(-)

Approvals:
  Rfaulk: Verified; Looks good to me, approved



diff --git a/sartoris/tests/test.py b/sartoris/tests/test.py
index da0a46e..3ce088f 100644
--- a/sartoris/tests/test.py
+++ b/sartoris/tests/test.py
@@ -48,13 +48,6 @@
     rmtree(config_local.TEST_REPO)
 
 
-class TestNullHandler(unittest.TestCase):
-    def test_emit(self):
-        # null_handler = NullHandler()
-        # self.assertEqual(expected, null_handler.emit(record))
-        assert False  # TODO: implement your test here
-
-
 class TestSartorisInit(unittest.TestCase):
     """ Test cases for Sartoris initialization and config """
     def test_conf_hook_dir(self):
@@ -98,6 +91,7 @@
         except SartorisError:
             assert False
 
+    @setup_deco
     def test_diff(self):
         """
         diff - test to ensure that ``diff`` method functions
@@ -109,6 +103,7 @@
         except SartorisError:
             assert False
 
+    @setup_deco
     def test_log_deploys(self):
         """
         log_deploys - test to ensure that ``log_deploys`` method functions
@@ -120,17 +115,7 @@
         except SartorisError:
             assert False
 
-    def test_resync(self):
-        """
-        resync - test to ensure that ``resync`` method functions
-        without exception
-        """
-        sartoris_obj = Sartoris()
-        try:
-            sartoris_obj.resync(None)
-        except SartorisError:
-            assert False
-
+    @setup_deco
     def test_revert(self):
         """
         revert - test to ensure that ``revert`` method functions

-- 
To view, visit https://gerrit.wikimedia.org/r/88696
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5ceee8da7e106b2b70e404ec10b4ef7eef97b4ec
Gerrit-PatchSet: 1
Gerrit-Project: sartoris
Gerrit-Branch: master
Gerrit-Owner: Rfaulk <rfaulk...@wikimedia.org>
Gerrit-Reviewer: Rfaulk <rfaulk...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to