Kipcool has submitted this change and it was merged.

Change subject: found \r bug in formatting
......................................................................


found \r bug in formatting

* removed \r in formatting CSVs
* renamed \t to \\t for good measure

Change-Id: Ida14a176b2093982790beed5398a0111dae51d01
---
M includes/formatCSV.php
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Kipcool: Verified; Looks good to me, approved



diff --git a/includes/formatCSV.php b/includes/formatCSV.php
index c6eb8c3..7a4b0ea 100644
--- a/includes/formatCSV.php
+++ b/includes/formatCSV.php
@@ -20,6 +20,8 @@
                if ( $column == '""') {
                        return '';
                }
+               $column = preg_replace( '/\t/', '\\t', $column );
+               $column = preg_replace( '/\r/', '', $column );
                return preg_replace( '/\n/', '\\n', $column );
        }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/87999
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ida14a176b2093982790beed5398a0111dae51d01
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiLexicalData
Gerrit-Branch: master
Gerrit-Owner: Hiong3-eng5 <hiong3.e...@gmail.com>
Gerrit-Reviewer: Kipcool <kipmas...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to