jenkins-bot has submitted this change and it was merged. Change subject: (bug 55439) Fix an error when an image has an unknown media type ......................................................................
(bug 55439) Fix an error when an image has an unknown media type Change-Id: Ia133c004ca03e0a599eacbc81ff12409bbe7ff87 --- M ProofreadPage.body.php 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Tpt: Looks good to me, approved jenkins-bot: Verified diff --git a/ProofreadPage.body.php b/ProofreadPage.body.php index a22a189..9d985c6 100644 --- a/ProofreadPage.body.php +++ b/ProofreadPage.body.php @@ -229,9 +229,13 @@ $filePage = $wgContLang->parseFormattedNumber( $m[3] ); $params = array( 'width' => $width, 'page' => $filePage ); - $image->getHandler()->normaliseParams( $image, $params ); - $thumbName = $image->thumbName( $params ); - $fullURL = $image->getThumbUrl( $thumbName ); + $handler = $image->getHandler(); + if ( $handler && $handler->normaliseParams( $image, $params ) ) { + $thumbName = $image->thumbName( $params ); + $fullURL = $image->getThumbUrl( $thumbName ); + } else { + $fullURL = $image->getViewURL(); + } } else { $fullURL = $image->getViewURL(); } -- To view, visit https://gerrit.wikimedia.org/r/88217 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia133c004ca03e0a599eacbc81ff12409bbe7ff87 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ProofreadPage Gerrit-Branch: master Gerrit-Owner: Tpt <thoma...@hotmail.fr> Gerrit-Reviewer: Reedy <re...@wikimedia.org> Gerrit-Reviewer: Tpt <thoma...@hotmail.fr> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits