Cmcmahon has uploaded a new change for review. https://gerrit.wikimedia.org/r/88763
Change subject: editing controls to proper iframe ...................................................................... editing controls to proper iframe Change-Id: Ifc24e4fcc0fe4688ee8e8b277f54fe2582dcadaf --- M modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb 1 file changed, 3 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/63/88763/1 diff --git a/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb b/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb index 238e789..f6eef73 100644 --- a/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb +++ b/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb @@ -8,7 +8,6 @@ a(:decrease_indentation_on, title: 'Decrease indentation [SHIFT+TAB]') div(:container_disabled, class: 've-ui-widget ve-ui-widget-disabled ve-ui-flaggableElement-constructive ve-ui-pushButtonWidget') div(:content, class: 've-ce-documentNode ve-ce-branchNode') - text_area(:describe_change, id: 've-init-mw-viewPageTarget-saveDialog-editSummary') span(:downarrow, class: 've-ui-iconedElement-icon ve-ui-icon-down') span(:heading, text: 'Heading') a(:edit_ve, title: /Edit this page with VisualEditor/) @@ -19,7 +18,6 @@ div(:ip_warning, class: 've-init-mw-viewPageTarget-toolbar-editNotices-notice') span(:linksuggestion, text: 'http://www.example.com') span(:looks_good, class: 've-ui-labeledElement-label', text: 'Looks good to me') - checkbox(:minor_edit, id: 'wpMinoredit') span(:more_menu, text: 'More') span(:newpage_linksuggestion, text: 'DoesNotExist') div(:page_text, id: 'mw-content-text') @@ -29,7 +27,6 @@ span(:refs_link, text: 'Reference') div(:save_disabled, class: 've-ui-widget ve-ui-widget-disabled ve-ui-flaggableElement-constructive ve-ui-pushButtonWidget') span(:save_page, class: 've-ui-labeledElement-label', text: 'Save page') - span(:second_save_page, class: 've-ui-labeledElement-label', text: 'Save page', index: 1) span(:ve_bullets, class: 've-ui-iconedElement-icon ve-ui-icon-bullet-list') div(:ve_heading_menu, class: 've-ui-dropdownTool-icon ve-ui-icon-down') span(:ve_heading_ui, text: 'Paragraph') @@ -40,9 +37,11 @@ span(:transclusion, text: 'Transclusion') in_frame(:index => 0) do |frame| + checkbox(:minor_edit, id: 'wpMinoredit', frame: frame) div(:content_box, class: 've-ce-documentNode ve-ce-branchNode', frame: frame) span(:create_new, text:'Insert reference', frame: frame) div(:diff_view, class: 've-ui-mwSaveDialog-viewer', frame: frame) + text_area(:describe_change, index: 0, frame: frame) a(:ex, title: 'Close', frame: frame) span(:heading, text: 'Heading') div(:insert_reference, text: 'Insert reference', frame: frame) @@ -54,6 +53,7 @@ span(:review_changes, class: 've-ui-labeledElement-label', text: 'Review your changes', frame: frame) div(:ref_body, class:'ve-ui-window-head', frame: frame) span(:return_to_save, class: 've-ui-labeledElement-label', text: 'Return to save form', frame: frame) + span(:second_save_page, class: 've-ui-labeledElement-label', text: 'Save page', frame: frame) div(:ve_link_ui, class: 've-ui-window-head', frame: frame) span(:subheading1, text: 'Sub-heading 1') span(:subheading2, text: 'Sub-heading 2') @@ -84,5 +84,4 @@ text_field(:transclusion_textfield, index: 0, frame: frame) unordered_list(:suggestion_list, class: 've-ui-widget ve-ui-selectWidget ve-ui-clippableElement-clippable ve-ui-menuWidget ve-ui-textInputMenuWidget ve-ui-lookupWidget-menu ve-ui-mwTitleInputWidget-menu', frame: frame) end - end -- To view, visit https://gerrit.wikimedia.org/r/88763 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifc24e4fcc0fe4688ee8e8b277f54fe2582dcadaf Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Cmcmahon <cmcma...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
