Brion VIBBER has submitted this change and it was merged. Change subject: Fix for darkening area above details slider not extending far enough. ......................................................................
Fix for darkening area above details slider not extending far enough. Seen on iPad. Change-Id: If57fc04e1ae4fb87089a580c4976daf197bfe231 --- M Commons-iOS/DetailScrollViewController.m 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Brion VIBBER: Verified; Looks good to me, approved diff --git a/Commons-iOS/DetailScrollViewController.m b/Commons-iOS/DetailScrollViewController.m index 8b4f908..be812cd 100644 --- a/Commons-iOS/DetailScrollViewController.m +++ b/Commons-iOS/DetailScrollViewController.m @@ -1523,7 +1523,7 @@ viewAboveBackground_.translatesAutoresizingMaskIntoConstraints = NO; [backgroundView_ insertSubview:viewAboveBackground_ atIndex:0]; [self.view addConstraints:[NSLayoutConstraint constraintsWithVisualFormat:@"H:|[above]|" options:0 metrics:nil views:views]]; - [self.view addConstraints:[NSLayoutConstraint constraintsWithVisualFormat:@"V:[above(==background)]" options:0 metrics:nil views:views]]; + [self.view addConstraints:[NSLayoutConstraint constraintsWithVisualFormat:@"V:[above(1024)]" options:0 metrics:nil views:views]]; [self.view addConstraints:[NSLayoutConstraint constraintsWithVisualFormat:@"V:[above][background]" options:0 metrics:nil views:views]]; // Add background below slider @@ -1531,7 +1531,7 @@ viewBelowBackground_.translatesAutoresizingMaskIntoConstraints = NO; [backgroundView_ insertSubview:viewBelowBackground_ atIndex:0]; [self.view addConstraints:[NSLayoutConstraint constraintsWithVisualFormat:@"H:|[below]|" options:0 metrics:nil views:views]]; - [self.view addConstraints:[NSLayoutConstraint constraintsWithVisualFormat:@"V:[below(==background)]" options:0 metrics:nil views:views]]; + [self.view addConstraints:[NSLayoutConstraint constraintsWithVisualFormat:@"V:[below(1024)]" options:0 metrics:nil views:views]]; [self.view addConstraints:[NSLayoutConstraint constraintsWithVisualFormat:@"V:[background][below]" options:0 metrics:nil views:views]]; } -- To view, visit https://gerrit.wikimedia.org/r/88777 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If57fc04e1ae4fb87089a580c4976daf197bfe231 Gerrit-PatchSet: 1 Gerrit-Project: apps/ios/commons Gerrit-Branch: master Gerrit-Owner: Brion VIBBER <br...@wikimedia.org> Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org> Gerrit-Reviewer: Mhurd <mh...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits