jenkins-bot has submitted this change and it was merged.

Change subject: Remove silly test cases that are likely to fail
......................................................................


Remove silly test cases that are likely to fail

Nobody should be giving objects or arrays to addIdentifierQuotes() anyway

Change-Id: Ibebf5d32196ac5b80cd477aedfef982fd2c9a0e6
---
M tests/phpunit/includes/db/DatabaseMysqlBaseTest.php
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Chad: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/phpunit/includes/db/DatabaseMysqlBaseTest.php 
b/tests/phpunit/includes/db/DatabaseMysqlBaseTest.php
index 75c4837..8138b70 100644
--- a/tests/phpunit/includes/db/DatabaseMysqlBaseTest.php
+++ b/tests/phpunit/includes/db/DatabaseMysqlBaseTest.php
@@ -83,9 +83,6 @@
                        // will return with thoses:
                        array( '``', false ),
                        array( '`1`', true ),
-                       array( '`Array`', array() ),
-                       //array( '`Object`', new stdClass() ),
-                       // ^ Error: Object of class stdClass could not be 
converted to string
 
                        // We never know what could happen
                        array( '`0`', 0 ),

-- 
To view, visit https://gerrit.wikimedia.org/r/88915
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibebf5d32196ac5b80cd477aedfef982fd2c9a0e6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Chad <ch...@wikimedia.org>
Gerrit-Reviewer: Chad <ch...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to