[MediaWiki-commits] [Gerrit] Style cleanups for tangent left border and height - change (mediawiki...Flow)

[EBernhardson (Code Review)]

EBernhardson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/89323


Change subject: Style cleanups for tangent left border and height
......................................................................

Style cleanups for tangent left border and height

Tangent posts were moving around when the hover buttons were displayed,
sets a min-height so the buttons always fit without affecting post height.
Additionally apply the tangent left-border to only the first level of replies
rather than the existing broken border between related tangents

Change-Id: I29c73f5c02039ac27d59c283f398e83882b92b50
---
M modules/discussion/styles/post.less
M templates/post.html.php
2 files changed, 22 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/23/89323/1

diff --git a/modules/discussion/styles/post.less 
b/modules/discussion/styles/post.less
index 90f7a3a..fada2eb 100644
--- a/modules/discussion/styles/post.less
+++ b/modules/discussion/styles/post.less
@@ -6,6 +6,11 @@
        margin-top: 20px;
        padding-left: 22px;
 
+       // Leave space for hover buttons to not change the height
+       .flow-post-unmoderated {
+               min-height: 115px;
+       }
+
        .flow-creator {
                font-weight: bold;
                color: @post-title-color;
@@ -94,8 +99,10 @@
        }
 
        .flow-post-replies {
-               .flow-post-container{
-                       border-left: 1px solid #999;
+               border-left: 1px solid #999;
+               
+               .flow-post-replies {
+                       border-left: 0px solid transparent;
                }
        }
 
@@ -233,16 +240,18 @@
                        }
                }
        }
-}
 
-// hacky way to flatten conversation;
-// make anything over 2 indentation levels appear on same level
-.flow-post-container .flow-post-container .flow-post-container {
-       padding-left: 0px;
-       border-left: 0px transparent;
-}
+       .flow-post-container {
+               // hacky way to flatten conversation;
+               // make anything over 2 indentation levels appear on same level
+               margin-top: 0px;
+               .flow-post-container {
+                       padding-left: 0px;
+               }
 
-// hacky way to not allow replies on an already too-deep level of indentation
-.flow-post-container .flow-post-container .flow-reply-link {
-       display: none !important;
+               // hacky way to not allow replies on an already too-deep level 
of indentation
+               .flow-reply-link {
+                       display: none !important;
+               }
+       }
 }
diff --git a/templates/post.html.php b/templates/post.html.php
index b249239..6c9a518 100644
--- a/templates/post.html.php
+++ b/templates/post.html.php
@@ -45,7 +45,7 @@
        'data-post-id' => $post->getRevisionId()->getHex(),
 ) );
        echo Html::openElement( 'div', array(
-               'class' => $post->isModerated() ? 'flow-post 
flow-post-moderated' : 'flow-post',
+               'class' => $post->isModerated() ? 'flow-post 
flow-post-moderated' : 'flow-post flow-post-unmoderated',
                'data-post-id' => $post->getPostId()->getHex(),
                'id' => 'flow-post-' . $post->getPostId()->getHex(),
        ) ); ?>

-- 
To view, visit https://gerrit.wikimedia.org/r/89323
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I29c73f5c02039ac27d59c283f398e83882b92b50
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <ebernhard...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits