jenkins-bot has submitted this change and it was merged.
Change subject: Hygiene: Address FIXME for title building in MobileWatchlist
......................................................................
Hygiene: Address FIXME for title building in MobileWatchlist
Change-Id: Ie91fa3a825869c6f1d09145bf9d06ea1235d8456
---
M includes/specials/SpecialMobileWatchlist.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/specials/SpecialMobileWatchlist.php
b/includes/specials/SpecialMobileWatchlist.php
index 4e9205f..177fc63 100644
--- a/includes/specials/SpecialMobileWatchlist.php
+++ b/includes/specials/SpecialMobileWatchlist.php
@@ -464,7 +464,7 @@
$revId = $row->rc_this_oldid;
if ( $revId ) {
- $diffTitle = Title::makeTitle( NS_SPECIAL,
'MobileDiff/' . $revId ); // @fixme this seems lame
+ $diffTitle = SpecialPage::getTitleFor( 'MobileDiff',
$revId );
$diffLink = $diffTitle->getLocalUrl();
} else {
// hack -- use full log entry display
--
To view, visit https://gerrit.wikimedia.org/r/89342
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie91fa3a825869c6f1d09145bf9d06ea1235d8456
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: MaxSem <maxsem.w...@gmail.com>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
