jenkins-bot has submitted this change and it was merged.
Change subject: Hygiene: Remove dead code
......................................................................
Hygiene: Remove dead code
As the honey badger would say:
Nasty
Change-Id: I341e33b28f7fef7643746aac7a04dd4e08e215c2
(cherry picked from commit 939652e630cac946fabb678eee3f8c78728f3f84)
---
M includes/specials/SpecialMobileWatchlist.php
1 file changed, 0 insertions(+), 18 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/specials/SpecialMobileWatchlist.php
b/includes/specials/SpecialMobileWatchlist.php
index 4e9205f..6322b50 100644
--- a/includes/specials/SpecialMobileWatchlist.php
+++ b/includes/specials/SpecialMobileWatchlist.php
@@ -7,9 +7,6 @@
const FILTER_OPTION_NAME = 'mfWatchlistFilter';
private $filter,
- $seenTitles,
- $seenDays,
- $today,
$usePageImages,
$optionsChanged = false;
@@ -311,12 +308,6 @@
wfProfileIn( __METHOD__ );
$empty = $res->numRows() === 0;
- $this->seenTitles = array();
-
- if ( $feed ) {
- $this->today = $this->day( wfTimestamp() );
- $this->seenDays = array( $this->today => true );
- }
$output = $this->getOutput();
@@ -409,10 +400,6 @@
);
}
- private function day( $ts ) {
- return $this->getLanguage()->date( $ts, true );
- }
-
private function renderThumb( $row ) {
wfProfileIn( __METHOD__ );
@@ -453,11 +440,6 @@
$title = Title::makeTitle( $row->rc_namespace, $row->rc_title );
$titleText = $title->getPrefixedText();
- if ( array_key_exists( $titleText, $this->seenTitles ) ) {
- // todo: skip seen titles and show only the latest?
- // return;
- }
- $this->seenTitles[$titleText] = true;
$comment = $row->rc_comment;
$ts = new MWTimestamp( $row->rc_timestamp );
--
To view, visit https://gerrit.wikimedia.org/r/89281
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I341e33b28f7fef7643746aac7a04dd4e08e215c2
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: MaxSem <maxsem.w...@gmail.com>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
