jenkins-bot has submitted this change and it was merged.
Change subject: Regression: talk icon in user profile
......................................................................
Regression: talk icon in user profile
Fix styling issue brought in by Idf4db1019ebdeeca23108a86eb7d8102096fecc3
Change-Id: I0b00703ab7deaf4f1ae2c91fd6a5e77b86a1e256
---
M javascripts/specials/nearby.js
M less/common/ui.less
M less/specials/nearby.less
M less/specials/userprofile.less
4 files changed, 5 insertions(+), 11 deletions(-)
Approvals:
JGonera: Looks good to me, approved
jenkins-bot: Verified
diff --git a/javascripts/specials/nearby.js b/javascripts/specials/nearby.js
index 8c7bc10..b92b4ab 100644
--- a/javascripts/specials/nearby.js
+++ b/javascripts/specials/nearby.js
@@ -43,7 +43,7 @@
$userBtn.remove();
}
// FIXME: i18n
- btn = $( '<button class="refresh">' ).on( 'click', refresh ).appendTo(
'.header' );
+ btn = $( '<button class="refresh" id="secondary-button">' ).on(
'click', refresh ).appendTo( '.header' );
} );
}( mw.mobileFrontend, jQuery ) );
diff --git a/less/common/ui.less b/less/common/ui.less
index f4bdabd..aff3bf7 100644
--- a/less/common/ui.less
+++ b/less/common/ui.less
@@ -21,6 +21,9 @@
/* Menu buttons */
#mw-mf-main-menu-button,
#secondary-button {
+ // Needed for Special:UserProfile and Special:Nearby
+ .background-size( auto, 24px );
+ border: none;
height: @headerHeight;
width: @searchBarPaddingLeft;
position: absolute;
diff --git a/less/specials/nearby.less b/less/specials/nearby.less
index d908291..5de59a5 100644
--- a/less/specials/nearby.less
+++ b/less/specials/nearby.less
@@ -31,16 +31,6 @@
// FIXME: has to be button to have precendence over button styling. Would be
nice to be just .refresh
button.refresh {
background: rgba(0, 0, 0, 0) url(images/refresh.png) no-repeat center
center;
- margin: 0;
- text-indent: -9999px;
- overflow: hidden;
- width: 24px;
- height: @headerHeight;
- background-size: 24px 25px;
- border: none;
- position: absolute;
- right: 0;
- top: 0;
}
.client-js {
diff --git a/less/specials/userprofile.less b/less/specials/userprofile.less
index 7aa1d00..b5e1c96 100644
--- a/less/specials/userprofile.less
+++ b/less/specials/userprofile.less
@@ -1,4 +1,5 @@
@import "../mixins.less";
+
.profile {
// FIXME: reconsider top margin for all pages?
margin-top: 1.5em;
--
To view, visit https://gerrit.wikimedia.org/r/89130
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b00703ab7deaf4f1ae2c91fd6a5e77b86a1e256
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: JGonera <jgon...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
