Tobias Gritschacher has submitted this change and it was merged. Change subject: (hotfix) SiteLinksEditTool: Address correct scope ......................................................................
(hotfix) SiteLinksEditTool: Address correct scope (cherry picked from commit 3173390d1b43fb120e6f3e9c477444b24d95f707) Change-Id: I34ea881422212bb2b0f30bfaaf481a230e029678 --- M lib/resources/wikibase.ui.SiteLinksEditTool.js 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Tobias Gritschacher: Verified; Looks good to me, approved diff --git a/lib/resources/wikibase.ui.SiteLinksEditTool.js b/lib/resources/wikibase.ui.SiteLinksEditTool.js index 94615b0..97694ad 100644 --- a/lib/resources/wikibase.ui.SiteLinksEditTool.js +++ b/lib/resources/wikibase.ui.SiteLinksEditTool.js @@ -135,6 +135,8 @@ * @return {wb.ui.PropertyEditTool.EditableValue} */ enterNewValue: function( value ) { + var self = this; + this._initializeSiteLinksTableHeader(); // Have the editableValues prototype regenerated each time a new value is about to be @@ -148,7 +150,8 @@ $( newValue ).on( 'afterStopEditing', function( event, save, wasPending ) { if ( save ) { - var $siteLinksTable = this._subject; + var $siteLinksTable = self._subject; + // move appended site link into the table body to have it included in sorting this.getSubject().appendTo( $siteLinksTable.children( 'tbody' ) ); -- To view, visit https://gerrit.wikimedia.org/r/89688 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34ea881422212bb2b0f30bfaaf481a230e029678 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: mw1.22-wmf21 Gerrit-Owner: Tobias Gritschacher <tobias.gritschac...@wikimedia.de> Gerrit-Reviewer: Henning Snater <henning.sna...@wikimedia.de> Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits