jenkins-bot has submitted this change and it was merged. Change subject: Remove unused local variables ......................................................................
Remove unused local variables Change-Id: If708a112ae6df070da19f52682f0e2b19fe67959 --- M AbuseFilter.class.php M AbuseFilter.hooks.php M AbuseFilter.parser.php 3 files changed, 3 insertions(+), 4 deletions(-) Approvals: Alex Monk: Looks good to me, approved jenkins-bot: Verified diff --git a/AbuseFilter.class.php b/AbuseFilter.class.php index aa53692..9fc5664 100644 --- a/AbuseFilter.class.php +++ b/AbuseFilter.class.php @@ -974,7 +974,7 @@ $local_log_ids = array(); global $wgAbuseFilterNotifications, $wgAbuseFilterNotificationsPrivate; - foreach ( $log_rows as $index => $data ) { + foreach ( $log_rows as $data ) { $data['afl_var_dump'] = $var_dump; $data['afl_id'] = $dbw->nextSequenceValue( 'abuse_filter_log_afl_id_seq' ); $dbw->insert( 'abuse_filter_log', $data, __METHOD__ ); diff --git a/AbuseFilter.hooks.php b/AbuseFilter.hooks.php index c042452..42c362d 100644 --- a/AbuseFilter.hooks.php +++ b/AbuseFilter.hooks.php @@ -29,7 +29,7 @@ // poor man's PST, see bug 20310 $text = str_replace( "\r\n", "\n", $text ); - $continue = self::filterEdit( $context, null, $text, $status, $summary, $minoredit ); + self::filterEdit( $context, null, $text, $status, $summary, $minoredit ); if ( !$status->isOK() ) { $msg = $status->getErrorsArray(); diff --git a/AbuseFilter.parser.php b/AbuseFilter.parser.php index 13c5428..5b77a98 100644 --- a/AbuseFilter.parser.php +++ b/AbuseFilter.parser.php @@ -707,8 +707,7 @@ */ protected function move( ) { wfProfileIn( __METHOD__ ); - list( $val, $type, $code, $offset ) = - self::nextToken( $this->mCode, $this->mPos ); + list( $val, $type, , $offset ) = self::nextToken( $this->mCode, $this->mPos ); $token = new AFPToken( $type, $val, $this->mPos ); $this->mPos = $offset; -- To view, visit https://gerrit.wikimedia.org/r/89736 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If708a112ae6df070da19f52682f0e2b19fe67959 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/AbuseFilter Gerrit-Branch: master Gerrit-Owner: Siebrand <siebr...@wikimedia.org> Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org> Gerrit-Reviewer: Alex Monk <kren...@gmail.com> Gerrit-Reviewer: Hoo man <h...@online.de> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits