Siebrand has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/89818


Change subject: Create consistent return point
......................................................................

Create consistent return point

Change-Id: Iaca35d1d9e94c027b580ead8bec102d1f6306105
---
M AbuseFilter.class.php
1 file changed, 7 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/AbuseFilter 
refs/changes/18/89818/1

diff --git a/AbuseFilter.class.php b/AbuseFilter.class.php
index 9fc5664..61939ce 100644
--- a/AbuseFilter.class.php
+++ b/AbuseFilter.class.php
@@ -1429,7 +1429,7 @@
        /**
         * @param $type
         * @param $title Title
-        * @return Int|string
+        * @return int|string
         */
        public static function throttleIdentifier( $type, $title ) {
                global $wgUser, $wgRequest;
@@ -1453,9 +1453,13 @@
                                $identifier = $wgUser->getEditCount();
                                break;
                        case 'site':
-                               return 1;
+                               $identifier = 1;
+                               break;
                        case 'page':
-                               return $title->getPrefixedText();
+                               $identifier = $title->getPrefixedText();
+                               break;
+                       default:
+                               $identifier = 0;
                }
 
                return $identifier;

-- 
To view, visit https://gerrit.wikimedia.org/r/89818
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaca35d1d9e94c027b580ead8bec102d1f6306105
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AbuseFilter
Gerrit-Branch: master
Gerrit-Owner: Siebrand <siebr...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to