Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/90262
Change subject: Cleanup on save dialog cruft & fix updateWatchLink
......................................................................
Cleanup on save dialog cruft & fix updateWatchLink
Change-Id: I730003726db0164e1bef8bddcd45e31df1373618
---
M modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
1 file changed, 4 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/62/90262/1
diff --git a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
index bc207ec..c4a589e 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
@@ -42,10 +42,6 @@
this.toolbarHelpButton = null;
this.toolbarFeedbackButton = null;
this.toolbarMetaButton = null;
-
- this.$saveDialog = $( '<div>' )
- .addClass( 've-init-mw-viewPageTarget-saveDialog' );
-
this.onBeforeUnloadFallback = null;
this.onBeforeUnloadHandler = null;
this.active = false;
@@ -317,9 +313,10 @@
// Just checking for mw.page.watch is not enough because in
Firefox
// there is Object.prototype.watch...
if ( mw.page.watch && mw.page.watch.updateWatchLink ) {
- var watchChecked = this.$saveDialog
- .find( '#wpWatchthis' )
- .prop( 'checked' );
+ var watchChecked = this.saveDialog.$saveOptions
+ .find( '.ve-ui-mwSaveDialog-checkboxes' )
+ .find( '#wpWatchthis' )
+ .prop( 'checked' );
mw.page.watch.updateWatchLink(
$( '#ca-watch a, #ca-unwatch a' ),
watchChecked ? 'unwatch': 'watch'
--
To view, visit https://gerrit.wikimedia.org/r/90262
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I730003726db0164e1bef8bddcd45e31df1373618
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Robmoen <rm...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
