Brion VIBBER has submitted this change and it was merged.
Change subject: Fix bug in new Win 8.1 search (broken backspace)
......................................................................
Fix bug in new Win 8.1 search (broken backspace)
Change-Id: I5154887709f61072c07e6c780de4c78db381d30e
---
M WikipediaMetro/WikipediaMetroTest/js/default.js
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Brion VIBBER: Verified; Looks good to me, approved
diff --git a/WikipediaMetro/WikipediaMetroTest/js/default.js
b/WikipediaMetro/WikipediaMetroTest/js/default.js
index cf06f94..284b89c 100644
--- a/WikipediaMetro/WikipediaMetroTest/js/default.js
+++ b/WikipediaMetro/WikipediaMetroTest/js/default.js
@@ -189,8 +189,12 @@
$(document).bind('keydown', function (event) {
// Backspace to go back
if (event.keyCode == 8) {
- doGoBack();
- event.preventDefault();
+ if ($(event.target).closest('.win-searchbox').length) {
+ // But don't eat backspaces from search box!
+ } else {
+ doGoBack();
+ event.preventDefault();
+ }
}
if (event.ctrlKey && event.keyCode == 'F'.charCodeAt(0)) {
if (state.current().type == 'article') {
--
To view, visit https://gerrit.wikimedia.org/r/90479
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5154887709f61072c07e6c780de4c78db381d30e
Gerrit-PatchSet: 1
Gerrit-Project: apps/win8/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
