Brion VIBBER has uploaded a new change for review.
https://gerrit.wikimedia.org/r/90637
Change subject: Fix regression: was crashing when changing orientation on detail
......................................................................
Fix regression: was crashing when changing orientation on detail
When changing orientation on the detail view, we were getting
a crash. This was due to the ContributionActivity's GridView's
ListAdapter not being set yet when the MediaDetailFragment got
reinitialized -- so when it tried to load its Media object from
the parent activity's list adapter it exploded with a null.
Since we don't have different layouts for orientations here,
there's no need to recreate the whole activity. Just changed
the options to retain the activity across such changes.
Change-Id: I269d22c50258ba3288fa2f43651db80a570b3b20
---
M commons/AndroidManifest.xml
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/commons
refs/changes/37/90637/1
diff --git a/commons/AndroidManifest.xml b/commons/AndroidManifest.xml
index 5ad1c77..d7315e9 100644
--- a/commons/AndroidManifest.xml
+++ b/commons/AndroidManifest.xml
@@ -71,6 +71,7 @@
android:name=".contributions.ContributionsActivity"
android:icon="@drawable/ic_launcher"
android:label="@string/app_name"
+ android:configChanges="keyboardHidden|orientation|screenSize"
>
<intent-filter>
<category android:name="android.intent.category.LAUNCHER"/>
--
To view, visit https://gerrit.wikimedia.org/r/90637
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I269d22c50258ba3288fa2f43651db80a570b3b20
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/commons
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER <br...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
