Cmcmahon has uploaded a new change for review. https://gerrit.wikimedia.org/r/91096
Change subject: add when_present clauses to reduce flaky test failures ...................................................................... add when_present clauses to reduce flaky test failures Change-Id: I4a7e2312d46ba1606490c81a4c6a3810cd15e0e9 --- M features/step_definitions/upload_wizard_steps.rb 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests refs/changes/96/91096/1 diff --git a/features/step_definitions/upload_wizard_steps.rb b/features/step_definitions/upload_wizard_steps.rb index 688f5bc..4a6f94c 100644 --- a/features/step_definitions/upload_wizard_steps.rb +++ b/features/step_definitions/upload_wizard_steps.rb @@ -13,10 +13,10 @@ on(DescribePage).next_element.click end When(/^I click Next button at Learn page$/) do - on(LearnPage).next_element.click + on(LearnPage).next_element.when_present.click end When(/^I click Next button at Release rights page$/) do - on(ReleaseRightsPage).next_element.click + on(ReleaseRightsPage).next_element.when_present.click end When(/^I click This file is my own work$/) do on(ReleaseRightsPage).select_my_own_work @@ -34,7 +34,7 @@ visit UploadWizardPage end When(/^thumbnail should be visible$/) do - on(ReleaseRightsPage).thumbnail_element.should be_visible + on(ReleaseRightsPage).thumbnail_element.when_present.should be_visible end When(/^upload file (.+)$/) do |file_name| require 'tempfile' -- To view, visit https://gerrit.wikimedia.org/r/91096 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4a7e2312d46ba1606490c81a4c6a3810cd15e0e9 Gerrit-PatchSet: 1 Gerrit-Project: qa/browsertests Gerrit-Branch: master Gerrit-Owner: Cmcmahon <cmcma...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
