[MediaWiki-commits] [Gerrit] Prevent against future badly behaving userCan hook implement... - change (mediawiki...ZeroRatedMobileAccess)

[Dr0ptp4kt (Code Review)]

Dr0ptp4kt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/91814


Change subject: Prevent against future badly behaving userCan hook 
implementations.
......................................................................

Prevent against future badly behaving userCan hook implementations.

* Current version works.
* This is to defend against potential mis-programmed userCan hook delegates.

Change-Id: If1d85004629db0c9a94821b41c99bd430d268339
---
M includes/ConfigPageHooks.php
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ZeroRatedMobileAccess 
refs/changes/14/91814/1

diff --git a/includes/ConfigPageHooks.php b/includes/ConfigPageHooks.php
index 4c6cbdb..70b5b33 100644
--- a/includes/ConfigPageHooks.php
+++ b/includes/ConfigPageHooks.php
@@ -134,6 +134,7 @@
                                }
                        }
                        // Otherwise prohibit any zero namespace editing
+                       $result = false;
                        return false;
                } else {
                        return true;

-- 
To view, visit https://gerrit.wikimedia.org/r/91814
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If1d85004629db0c9a94821b41c99bd430d268339
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ZeroRatedMobileAccess
Gerrit-Branch: master
Gerrit-Owner: Dr0ptp4kt <ab...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits